Skip to content

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Sep 2, 2025

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.0
    • 3.5
    • 3.4
    • 3.3

@Seaven Seaven requested review from a team as code owners September 2, 2025 02:48
@mergify mergify bot assigned Seaven Sep 2, 2025
@Seaven Seaven force-pushed the copilot/vscode1756266668061 branch from 1dbcbf9 to 665ef2d Compare September 2, 2025 02:52
@Seaven Seaven changed the title [Refactor] refact expr explain&toSQL [Refactor] refactor expr explain&toSQL Sep 2, 2025
@alvin-celerdata
Copy link
Contributor

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


Signed-off-by: Seaven <seaven_7@qq.com>
@Seaven Seaven force-pushed the copilot/vscode1756266668061 branch from 2709326 to 5bdcadb Compare September 2, 2025 07:14
Signed-off-by: Seaven <seaven_7@qq.com>
Signed-off-by: Seaven <seaven_7@qq.com>
Signed-off-by: Seaven <seaven_7@qq.com>
Copy link

github-actions bot commented Sep 2, 2025

[FE Incremental Coverage Report]

fail : 3 / 10 (30.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/analysis/SubfieldExpr.java 0 1 00.00% [80]
🔵 com/starrocks/sql/ast/LambdaFunctionExpr.java 0 1 00.00% [60]
🔵 com/starrocks/analysis/SlotRef.java 0 4 00.00% [271, 272, 273, 274]
🔵 com/starrocks/analysis/Expr.java 0 1 00.00% [575]
🔵 com/starrocks/analysis/FunctionCallExpr.java 2 2 100.00% []
🔵 com/starrocks/analysis/CastExpr.java 1 1 100.00% []

f
Signed-off-by: Seaven <seaven_7@qq.com>
x
Signed-off-by: Seaven <seaven_7@qq.com>
Copy link

sonarqubecloud bot commented Sep 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

github-actions bot commented Sep 2, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 2, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants