Skip to content

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Sep 1, 2025

Why I'm doing:

When creating materialized views based on Hive external tables, if the partition expression column name case doesn't match the base table partition column name (e.g., base table partition column is l_shipdate, but expression uses L_SHIPDATE), the validation would fail and throw "Materialized view partition column in partition exp must be base table partition column" error.

What I'm doing:

Modified partition column validation logic in MaterializedViewAnalyzer.java

Fixes #issue
#62597

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.0
    • 3.5
    • 3.4
    • 3.3

…ed view analyzer

Signed-off-by: stephen <stephen5217@163.com>
Copy link

sonarqubecloud bot commented Sep 1, 2025

Copy link

github-actions bot commented Sep 2, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 2, 2025

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java 1 1 100.00% []

Copy link

github-actions bot commented Sep 2, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby merged commit 9798ba7 into StarRocks:main Sep 2, 2025
81 of 87 checks passed
Copy link

github-actions bot commented Sep 2, 2025

@Mergifyio backport branch-3.3

Copy link

github-actions bot commented Sep 2, 2025

@Mergifyio backport branch-3.5

@github-actions github-actions bot removed the 3.3 label Sep 2, 2025
Copy link

github-actions bot commented Sep 2, 2025

@Mergifyio backport branch-4.0

Copy link

github-actions bot commented Sep 2, 2025

@Mergifyio backport branch-3.4

Copy link
Contributor

mergify bot commented Sep 2, 2025

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 2, 2025

backport branch-3.5

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 2, 2025

backport branch-4.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 2, 2025

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2025
…ed view analyzer (#62598)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit 9798ba7)
mergify bot pushed a commit that referenced this pull request Sep 2, 2025
…ed view analyzer (#62598)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit 9798ba7)
mergify bot pushed a commit that referenced this pull request Sep 2, 2025
…ed view analyzer (#62598)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit 9798ba7)
mergify bot pushed a commit that referenced this pull request Sep 2, 2025
…ed view analyzer (#62598)

Signed-off-by: stephen <stephen5217@163.com>
(cherry picked from commit 9798ba7)
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2025
…ed view analyzer (backport #62598) (#62622)

Signed-off-by: stephen <stephen5217@163.com>
Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2025
…ed view analyzer (backport #62598) (#62621)

Signed-off-by: stephen <stephen5217@163.com>
Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2025
…ed view analyzer (backport #62598) (#62623)

Signed-off-by: stephen <stephen5217@163.com>
Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2025
…ed view analyzer (backport #62598) (#62620)

Signed-off-by: stephen <stephen5217@163.com>
Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants