Skip to content

fix: MultiDrag plugin in nested Sortables #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: MultiDrag plugin in nested Sortables #2421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions plugins/MultiDrag/MultiDrag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,10 @@ function MultiDragPlugin() {

// Move element(s) to end of parentEl so that it does not interfere with multi-drag clones insertion if they are inserted
// while folding, and so that we can capture them again because old sortable will no longer be fromSortable
parentEl.appendChild(multiDragElement);
if (!multiDragElement.contains(parentEl)) {
// multiDragElement can't contains parentEl
parentEl.appendChild(multiDragElement);
}
});

folding = true;
Expand Down Expand Up @@ -423,7 +426,10 @@ function MultiDragPlugin() {
if (children[multiDragIndex]) {
parentEl.insertBefore(multiDragElement, children[multiDragIndex]);
} else {
parentEl.appendChild(multiDragElement);
if (!multiDragElement.contains(parentEl)) {
// multiDragElement can't contains parentEl
parentEl.appendChild(multiDragElement);
}
}
multiDragIndex++;
});
Expand Down