Socket fix and repo name adjustments #742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| const errorMessage = | ||
| (e as SpawnError)?.['stderr'] || (e as Error)?.['message'] || '' | ||
|
|
||
| // Success cases: Socket detected an issue. |
There was a problem hiding this comment.
The if statement on line 112 is missing curly braces. According to the control structures rule, all control structures must use curly braces even for single statements. The code should be: if (errorMessage.includes('typosquat')) { continue }
Spotted by Diamond (based on custom rule: Custom rules)
Is this helpful? React 👍 or 👎 to let us know.
|
The 🐉 are now slumbering. All is 🟢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
--only-computeflag to--dont-apply-fixejsforsocket fix, but keep old flag as an alias.Fixed
The Socket backend validates repository names to ensure they work with GitHub's naming rules. However, GitHub's constraints differ from other platforms like GitLab, so names that work on one platform may not work on another. The
sanitizeNamefunction modifies extracted repository names to be compatible with Socket/GitHub.