gccrs: Fix ICE with invalid const expression #4150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philberty
force-pushed
the
phil/const-crash
branch
from
d5cea97 to
9805aee
Compare
This patch handles the overflowed var expression in the const block, so that we error properly in the const expr code. It was missing some stuff from the c++ implementation in how this should be handled properly. Fixes #4139 gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (CompileExpr::compile_integer_literal): cleanup * backend/rust-constexpr.cc (struct constexpr_global_ctx): port over c++ helpers (decl_really_constant_value): likewise (eval_constant_expression): likewise (non_const_var_error): likewise gcc/testsuite/ChangeLog: * rust/compile/issue-4139.rs: New test. Signed-off-by: Philip Herron <herron.philip@googlemail.com>
philberty
force-pushed
the
phil/const-crash
branch
from
9805aee to
f1445f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch handles the overflowed var expression in the const block, so that we error properly in the const expr code. It was missing some stuff from the c++ implementation in how this should be handled properly.
Fixes #4139
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: