Skip to content

fix(windows): fixing tests on windows #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(windows): fixing tests on windows #752

wants to merge 2 commits into from

Conversation

ggodik
Copy link

@ggodik ggodik commented Apr 4, 2022 •
edited
Loading

Found a few windows specific unit test issues

  • config.TestReadFromFile breaks because windows reads in carriage returns and the hardcoded string does not have these. Fixed by making test content on the fly.
  • util.GetLockName failes because the expected output does not contain a file with .exe extension. Fixed by removing .exe on Windows
  • moved magic file length constant 1000 to ConfigMaxSize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rkoehl05 rkoehl05 rkoehl05 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggodik @rkoehl05