Skip to content

quick fix to allow vapor liquid interface to accept T as function #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

quick fix to allow vapor liquid interface to accept T as function #241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
363b8f7
quick fix to allow VaporLiquidMassTransferInternalInterfaceConstantT …
donerancl Nov 8, 2023
294f1ee
Update Interface.jl
donerancl Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/Interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,14 +392,25 @@ function VaporLiquidMassTransferInternalInterfaceConstantT(domaingas,domainliq,i
T = domainliq.T
phase = domainliq.phase
ignoremasstransferspcinds = getinterfaceignoremasstransferspcinds(domaingas,domainliq,ignoremasstransferspcnames)
kLAs = [kLA(T=T) for kLA in getfield.(phase.species,:liquidvolumetricmasstransfercoefficient)]
kHs = [kH(T=T) for kH in getfield.(phase.species,:henrylawconstant)]
if T isa Function
kLAs = [kLA(T=T(0)) for kLA in getfield.(phase.species,:liquidvolumetricmasstransfercoefficient)]
kHs = [kH(T=T(0)) for kH in getfield.(phase.species,:henrylawconstant)]
else
kLAs = [kLA(T=T) for kLA in getfield.(phase.species,:liquidvolumetricmasstransfercoefficient)]
kHs = [kH(T=T) for kH in getfield.(phase.species,:henrylawconstant)]
end
return VaporLiquidMassTransferInternalInterfaceConstantT(domaingas,domainliq,ignoremasstransferspcnames,ignoremasstransferspcinds,kLAs,kHs,[1,length(domainliq.phase.species)],[0,0],ones(length(domainliq.phase.species))),ones(length(domainliq.phase.species))
end
export VaporLiquidMassTransferInternalInterfaceConstantT





function getkLAkHs(vl::VaporLiquidMassTransferInternalInterfaceConstantT,Tgas,Tliq)
return vl.kLAs, vl.kHs
kLAs = [kLA(T=Tliq) for kLA in getfield.(vl.domainliq.phase.species,:liquidvolumetricmasstransfercoefficient)]
kHs = [kH(T=Tliq) for kH in getfield.(vl.domainliq.phase.species,:henrylawconstant)]
return kLAs, kHs
end

function evaluate(vl::VaporLiquidMassTransferInternalInterfaceConstantT,dydt,Vgas,Vliq,Tgas,Tliq,N1,N2,P1,P2,Cvave1,Cvave2,ns1,ns2,Us1,Us2,cstot,p)
Expand Down Expand Up @@ -534,4 +545,4 @@ function evaluate(ri::FragmentBasedReactiveFilmGrowthInterfaceConstantT,dydt,dom
addreactionratecontributions!(dydt,ri.fragmentbasedrxnarray,ri.rxnarray,cstot,kfs,krevs,Vfilm,domainfilm.indexes[3],ri.Mws,domainfilm.indexes[1]:domainfilm.indexes[2])
end

export evaluate
export evaluate