chore: clip dialogue window #37576
Merged
chore: clip dialogue window #37576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
frontend/src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts
Outdated
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/player/controller/ClipRecording.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: -54 B (0%) Total Size: 2.71 MB ℹ️ View Unchanged
|
veryayskiy
requested review from
a team,
pauldambra and
TueHaulund
and removed request for
a team
pauldambra
reviewed
Sep 4, 2025
frontend/src/scenes/session-recordings/player/controller/ClipRecording.tsx
Outdated
Show resolved
Hide resolved
pauldambra
reviewed
Sep 4, 2025
pauldambra
reviewed
Sep 4, 2025
frontend/src/scenes/session-recordings/player/controller/ClipRecording.tsx
Show resolved
Hide resolved
veryayskiy
commented
Sep 4, 2025
| showingClipParams: [ | ||
| false as boolean, | ||
| { | ||
| setShowingClipParams: (_, { showingClipParams }) => showingClipParams, |
There was a problem hiding this comment.
We should have only one layover at any given time
veryayskiy
commented
Sep 4, 2025
frontend/src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts
Show resolved
Hide resolved
pauldambra
reviewed
Sep 4, 2025
TueHaulund
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by comments overlay
Let's allow to pick the format GIF / MP4
Let's allow to pick a duration 5-30 seconds