-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(ui): improve Cancel button visibility in delete-project-dialog #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@megh-bari is attempting to deploy a commit to the OpenCut OSS Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for appcut pending review.Visit the deploys page to approve it
|
WalkthroughA UI prop change updates the Cancel button style in the DeleteProjectDialog component from variant "text" to "outline". No logic, behavior, or exports changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (5)**/*.{jsx,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{js,jsx,ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{tsx,jsx}📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)
Files:
🧬 Code graph analysis (1)apps/web/src/components/delete-project-dialog.tsx (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Bro, I observed a bit too deeply (fe dev instincts). I just love clean and polished UIs. hope you like this tiny contribution xd |
Description
Changed the Cancel button variant in the delete project dialog for better visibility and clearer differentiation from the destructive action.
apps/web/src/components/delete-project-dialog.tsx
variant="text"
➝variant="outline"
This ensures the Cancel button has a border, improving UX and accessibility.
Fixes: N/A
Type of change
How Has This Been Tested?
Test Configuration:
Screenshots
Before (
variant="text"
)After (
variant="outline"
)Checklist:
Additional context
Cancel finally looks like a button, not a polite suggestion.
Summary by CodeRabbit