Skip to content

Conversation

hduoc2003
Copy link

Added a bold ASCII banner to neptune-core, neptune-cli, and neptune-dashboard for improved visual identity on startup.

image

Copy link
Contributor

@aszepieniec aszepieniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely contribution, thank you :-)

I left some minor change requests inline.

About the neptune-banner.txt asset file, could you explain to me how it works? What I'm concerned about is shipping the executable with a text file, and having that executable crash if the text file is not present. However, if the content of this txt file ends up as part of the executable, then it's all good in my book.

@KaffinPX
Copy link
Contributor

KaffinPX commented Aug 5, 2025

can we wait until crate separation PR bcs this would probably cause too many annoying conflicts?

@hduoc2003
Copy link
Author

Lovely contribution, thank you :-)

I left some minor change requests inline.

About the neptune-banner.txt asset file, could you explain to me how it works? What I'm concerned about is shipping the executable with a text file, and having that executable crash if the text file is not present. However, if the content of this txt file ends up as part of the executable, then it's all good in my book.

Lovely contribution, thank you :-)

I left some minor change requests inline.

About the neptune-banner.txt asset file, could you explain to me how it works? What I'm concerned about is shipping the executable with a text file, and having that executable crash if the text file is not present. However, if the content of this txt file ends up as part of the executable, then it's all good in my book.

It actually gets embedded into the executable at build time, so it doesn’t rely on an external file at runtime sir.

@aszepieniec aszepieniec mentioned this pull request Aug 10, 2025
7 tasks
@aszepieniec
Copy link
Contributor

I am getting identical pictures if I change the line

println!("{}", NEPTUNE_BANNER.fg_rgb::<255, 255, 255>().bold());

into

println!("{}", NEPTUNE_BANNER);

.

At this point, new dependency owo-colors is not used. Is there something I'm not seeing? Does something break if we drop it? I prefer fewer dependencies to begin with but if there is not even any difference, there's a very easy case for dropping it ...

@hduoc2003
Copy link
Author

I am getting identical pictures if I change the line

println!("{}", NEPTUNE_BANNER.fg_rgb::<255, 255, 255>().bold());

into

println!("{}", NEPTUNE_BANNER);

.

At this point, new dependency owo-colors is not used. Is there something I'm not seeing? Does something break if we drop it? I prefer fewer dependencies to begin with but if there is not even any difference, there's a very easy case for dropping it ...

Here is the result, sir. It's just ... not bold :)
image

@aszepieniec
Copy link
Contributor

Right, so bold makes a difference. That leaves the main question, which is: is owo-colors necessary?

@hduoc2003
Copy link
Author

Right, so bold makes a difference. That leaves the main question, which is: is owo-colors necessary?

Right, so bold makes a difference. That leaves the main question, which is: is owo-colors necessary?

owo-colors is a Rust crate for styling terminal output (colors, bold, underline, etc.). We need it for bold text to work sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants