-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Add startup banner to CLI #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely contribution, thank you :-)
I left some minor change requests inline.
About the neptune-banner.txt
asset file, could you explain to me how it works? What I'm concerned about is shipping the executable with a text file, and having that executable crash if the text file is not present. However, if the content of this txt file ends up as part of the executable, then it's all good in my book.
can we wait until crate separation PR bcs this would probably cause too many annoying conflicts? |
a7a1f9f
to
bbae16b
Compare
It actually gets embedded into the executable at build time, so it doesn’t rely on an external file at runtime sir. |
bbae16b
to
1ca524b
Compare
I am getting identical pictures if I change the line println!("{}", NEPTUNE_BANNER.fg_rgb::<255, 255, 255>().bold()); into println!("{}", NEPTUNE_BANNER); . At this point, new dependency |
|
Right, so bold makes a difference. That leaves the main question, which is: is |
|
Added a bold ASCII banner to neptune-core, neptune-cli, and neptune-dashboard for improved visual identity on startup.