Leave bootstrap nodes alone if well connected #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to give bootstrap nodes an easier time at fulfilling their service, they should only be contacted if necessary. In order to stop connecting to them, nodes need to communicate their bootstrap status and track their peer's bootstrap status. BREAKING CHANGE: Add additional variants to the public enumeration `NegativePeerSanction`.
In order to help newcomers to connect to peers on the network, certain nodes act as bootstrap nodes. Those nodes tend to be well known, and users tend to specify them as potential peers via command line arguments. Previously, connections to potential peers specified as command line arguments were always re-initiated when dropped. This can cause an involuntary denial-of-service of those well-known bootstrap nodes. Now, a well-connected node does not initiate connections with bootstrap nodes.
3 tasks
|
You probably already found the problematic part of the code that causes the old node to hang up when receiving an unknown message type. It's here in peer_message = peer.try_next() => {
let peer_address = self.peer_address;
let peer_message = match peer_message {
Ok(message) => message,
Err(err) => {
let msg = format!("Error when receiving from peer: {peer_address}");
error!("{msg}. Error: {err}");
bail!("{msg}. Closing connection.");
}Currently this error causes the node to hang up. That behavior could be changed to e.g. log a warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to help newcomers to connect to peers on the network, certain nodes act as bootstrap nodes. Those nodes tend to be well known, and users tend to specify them as potential peers via command line arguments.
Previously, connections to potential peers specified as command line arguments were always re-initiated when dropped. This can cause an involuntary denial-of-service of those well-known bootstrap nodes.
With this PR, a well-connected node does not initiate connections with bootstrap nodes.
Second attempt of #488 after its reversal in 10e327b and ee37959.