Skip to content

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Sep 3, 2025

Description

This PR adds search functionality implementation for the Multichain Account List.

Notes:

  • Improvement for hiding wallet header for singular wallet is added (it was initial requirement for the list).
  • Create new account button is removed in search mode, as it doesn't make much sense to create account which name will be filtered already (not visible).

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Added search functionality to the Multichain Account List

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-370

Manual testing steps

  1. Go to multichain account list page while multichain state 2 feature flag is enabled.
  2. Test search by typing account names in the search bar.

Screenshots/Recordings

Before

Search was not available before. Nothing to show here.

After

Screenshot 2025-09-04 at 12 25 22 Screenshot 2025-09-04 at 12 25 40 Screenshot 2025-09-04 at 12 26 43 Screenshot 2025-09-04 at 12 25 02 Screenshot 2025-09-04 at 12 26 02 Screenshot 2025-09-04 at 12 26 34
Screen.Recording.2025-09-04.at.12.28.57.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd self-assigned this Sep 3, 2025
Copy link
Contributor

github-actions bot commented Sep 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd force-pushed the dd/multichain-account-search branch 2 times, most recently from 387960d to d71bd4d Compare September 3, 2025 18:30
@github-actions github-actions bot added the size-M label Sep 3, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Sep 3, 2025

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (6 files, +315 -56)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain-accounts/
        • 📁 multichain-account-list/
          • 📄 multichain-account-list.test.tsx +17 -1
          • 📄 multichain-account-list.tsx +12 -2
    • 📁 pages/
      • 📁 multichain-accounts/
        • 📁 account-list/
          • 📄 account-list.test.tsx +90 -45
          • 📄 account-list.tsx +86 -8
          • 📄 utils.test.ts +65 -0
          • 📄 utils.ts +45 -0

@metamaskbot
Copy link
Collaborator

❌ test-e2e-chrome-api-specs failed. View the html report here.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: a259fdf | Date: 9/3/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.28s (±53ms) 🟡 | historical mean value: 1.30s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 959ms (±50ms) 🟢 | historical mean value: 985ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 88ms (±22ms) 🟢 | historical mean value: 104ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.28s 53ms 1.25s 1.70s 1.34s 1.70s
domContentLoaded 959ms 50ms 935ms 1.36s 1.02s 1.36s
firstPaint 88ms 22ms 72ms 240ms 132ms 240ms
firstContentfulPaint 88ms 22ms 72ms 240ms 132ms 240ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [d71bd4d]
UI Startup Metrics (1247 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1247114115666912811375
load107793913666711101217
domContentLoaded106892913586811021211
domInteractive17145161726
firstPaint67174124343910921163
backgroundConnect24823340017251264
firstReactRender2717136152745
getState1354961524
initialActions51687511
loadScripts829688111567865969
setupStore962021015
WebpackHomeuiStartup20271504254124621912421
load16151217194218617471849
domContentLoaded16061207192118617401835
domInteractive161176101444
firstPaint1726541967224284
backgroundConnect3815337503360
firstReactRender95373807784326
getState3852807915275
initialActions10228232712
loadScripts16021204190918517381824
setupStore156284271524
FirefoxBrowserifyHomeuiStartup1394121817619714431561
load1213106515558212671344
domContentLoaded1213106515558212671344
domInteractive1003231346111210
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect38191332138100
firstReactRender27225352837
getState63577617
initialActions3063639
loadScripts1183104715338112391313
setupStore1159614829
WebpackHomeuiStartup16751450210816217941965
load14331229184115115691692
domContentLoaded14331228184015115681692
domInteractive1173535465106300
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3523111113948
firstReactRender46376454855
getState8214615719
initialActions411301339
loadScripts14071202181415115301671
setupStore963741019
Benchmark value 1247 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1078 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1068 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 249 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1376 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1218 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1211 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 970 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 38 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 210 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 100 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1675 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 118 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1407 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1965 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1692 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1692 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 300 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1671 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 559ms | Sum of p95 exceeds: 785.8ms
Sum of all benchmark exceeds: 1344.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 1.73 KiB (0.02%)
  • common: 142 Bytes (0%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 54ddfa2 | Date: 9/4/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.29s (±47ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 966ms (±45ms) 🟢 | historical mean value: 992ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 87ms (±14ms) 🟢 | historical mean value: 104ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.29s 47ms 1.26s 1.72s 1.33s 1.72s
domContentLoaded 966ms 45ms 942ms 1.39s 998ms 1.39s
firstPaint 87ms 14ms 72ms 160ms 124ms 160ms
firstContentfulPaint 87ms 14ms 72ms 160ms 124ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [ede1108]
UI Startup Metrics (1193 ± 59 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1193108913825912271293
load103595512035410651130
domContentLoaded102894611965510601124
domInteractive17134751733
firstPaint61881120542110401116
backgroundConnect2422282718245260
firstReactRender22165362336
getState1263451423
initialActions4063647
loadScripts79470294954826889
setupStore941721014
WebpackHomeuiStartup19571483264427221542419
load15721196194320317221881
domContentLoaded15621187193220217131863
domInteractive161177121440
firstPaint1656139062194294
backgroundConnect3116325313059
firstReactRender86373446584308
getState3253127014268
initialActions52234616
loadScripts15581184191920117111851
setupStore156290281324
FirefoxBrowserifyHomeuiStartup14181203187213014691687
load1224105014578712861382
domContentLoaded1224105014578712861381
domInteractive1113350569113245
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3620114183788
firstReactRender28235352936
getState63283612
initialActions41587312
loadScripts1197103314318612551358
setupStore12511919847
WebpackHomeuiStartup15041336208215015831792
load12821141159712013501539
domContentLoaded12811140159612013501539
domInteractive94313215491261
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect312010193639
firstReactRender42345854549
getState63677611
initialActions511221339
loadScripts12591116157111913301508
setupStore95334920
Benchmark value 242 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 7 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1418 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1687 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 245 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 88 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 47 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 261 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 287ms | Sum of p95 exceeds: 566.8ms
Sum of all benchmark exceeds: 853.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 4.04 KiB (0.05%)
  • common: 718 Bytes (0.01%)

@david0xd david0xd force-pushed the dd/multichain-account-search branch from fdc3380 to f800fec Compare September 4, 2025 10:30
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 80c1458 | Date: 9/4/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.31s (±119ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 985ms (±117ms) 🟢 | historical mean value: 991ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 93ms (±35ms) 🟢 | historical mean value: 102ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.31s 119ms 1.25s 2.19s 1.35s 2.19s
domContentLoaded 985ms 117ms 938ms 1.85s 1.02s 1.85s
firstPaint 93ms 35ms 72ms 292ms 140ms 292ms
firstContentfulPaint 93ms 35ms 72ms 292ms 140ms 292ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [f800fec]
UI Startup Metrics (1215 ± 82 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1215110018208212391327
load105495816948110791131
domContentLoaded104695416888110711124
domInteractive17134661738
firstPaint65372113141810551115
backgroundConnect2442312647248259
firstReactRender25177782539
getState1557991930
initialActions51566512
loadScripts810721145081835887
setupStore96172914
WebpackHomeuiStartup19921468250625321472417
load15881182197818617171850
domContentLoaded15781177195818517101833
domInteractive161156101341
firstPaint1656141458187279
backgroundConnect3714333523060
firstReactRender75373304580134
getState4143098414286
initialActions10228636614
loadScripts15741174194718417071822
setupStore176295391220
FirefoxBrowserifyHomeuiStartup14301207196211914971639
load1241105414007913011376
domContentLoaded1240105413997913011376
domInteractive1103134360115244
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3520169233588
firstReactRender27226052937
getState9221028612
initialActions31465310
loadScripts1214103513727712731354
setupStore95326927
WebpackHomeuiStartup15891379212916017231878
load13541172167713614841626
domContentLoaded13541172167613614831626
domInteractive102353185795265
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3321126133749
firstReactRender43366054750
getState6218269
initialActions411091139
loadScripts13301148165713714611607
setupStore125231231020
Benchmark value 244 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 41 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 286 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1431 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1241 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 244 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 88 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 265 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 320ms | Sum of p95 exceeds: 541.8ms
Sum of all benchmark exceeds: 861.8ms

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 1b284ec | Date: 9/4/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.30s (±90ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 982ms (±88ms) 🟢 | historical mean value: 991ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 94ms (±36ms) 🟢 | historical mean value: 102ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.30s 90ms 1.26s 1.89s 1.41s 1.89s
domContentLoaded 982ms 88ms 943ms 1.56s 1.08s 1.56s
firstPaint 94ms 36ms 72ms 264ms 188ms 264ms
firstContentfulPaint 94ms 36ms 72ms 264ms 188ms 264ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [c87d1e8]
UI Startup Metrics (1201 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1201111213405612471291
load104395711615210771133
domContentLoaded103595011515210691127
domInteractive17133841723
firstPaint64471113741910521102
backgroundConnect2422292728245262
firstReactRender23164652432
getState14587121631
initialActions50466512
loadScripts80171492153839888
setupStore86192813
WebpackHomeuiStartup19661460258328221402435
load15651178199921217071865
domContentLoaded15561168198821116981853
domInteractive1712117131443
firstPaint1706438761202288
backgroundConnect29156393052
firstReactRender82383395580274
getState4753139314298
initialActions6215915610
loadScripts15531165197620916951841
setupStore146243231323
FirefoxBrowserifyHomeuiStartup19371544227314520462181
load16731352196112817671895
domContentLoaded16721352195912817671894
domInteractive1414255890137386
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect62292533871142
firstReactRender36286963751
getState11411417917
initialActions42142511
loadScripts16251329193612717191863
setupStore15793161271
WebpackHomeuiStartup15631368201115316511901
load13421172176314014371626
domContentLoaded13421172176314014361626
domInteractive106614505999256
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3321105103746
firstReactRender42315644550
getState7313713611
initialActions407410311
loadScripts13181141174214114041605
setupStore105758923
Benchmark value 242 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 47 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 298 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1938 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1673 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1673 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 142 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 63 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1626 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 2181 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1895 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1894 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 386 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 142 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1863 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 71 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 256 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 2160ms | Sum of p95 exceeds: 2493.8ms
Sum of all benchmark exceeds: 4653.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 1.94 KiB (0.03%)
  • common: 142 Bytes (0%)

@david0xd david0xd marked this pull request as ready for review September 4, 2025 11:33
@david0xd david0xd requested a review from a team as a code owner September 4, 2025 11:33
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 7c61c2c | Date: 9/4/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.28s (±20ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 960ms (±17ms) 🟢 | historical mean value: 991ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 86ms (±15ms) 🟢 | historical mean value: 102ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.28s 20ms 1.26s 1.36s 1.32s 1.36s
domContentLoaded 960ms 17ms 937ms 1.04s 997ms 1.04s
firstPaint 86ms 15ms 72ms 164ms 116ms 164ms
firstContentfulPaint 86ms 15ms 72ms 164ms 116ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [b85f1eb]
UI Startup Metrics (1228 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1228109114617312781358
load106896312867111241211
domContentLoaded106095212827111161203
domInteractive17134251628
firstPaint66986122943710821170
backgroundConnect2442322757248256
firstReactRender23163742433
getState14588101831
initialActions50477613
loadScripts823704103270879960
setupStore951721013
WebpackHomeuiStartup22491638286225624162736
load17931312221119819342135
domContentLoaded17821300219519719212116
domInteractive2112205251686
firstPaint1756651870198312
backgroundConnect361695173786
firstReactRender1153936389115329
getState3553137018279
initialActions72193815
loadScripts17771298218319519092104
setupStore217291391842
FirefoxBrowserifyHomeuiStartup14001172181011914701610
load1213102814027912681331
domContentLoaded1213102714017912671331
domInteractive1083328154117244
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3418130203493
firstReactRender26223732935
getState829414617
initialActions3159639
loadScripts1187101213537812481312
setupStore1045210829
WebpackHomeuiStartup15801387215013416561815
load13531174162711414491574
domContentLoaded13531170162711414491574
domInteractive106373076199279
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect31205173646
firstReactRender443511394651
getState7311011612
initialActions512132236
loadScripts13311143160611514301555
setupStore96253916
Benchmark value 245 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1211 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1204 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 256 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 960 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2249 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1793 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1782 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 1778 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2736 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2136 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2116 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 87 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2104 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 244 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 93 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 279 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 579ms | Sum of p95 exceeds: 1278.8ms
Sum of all benchmark exceeds: 1857.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 1.83 KiB (0.02%)
  • common: 142 Bytes (0%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: ea8bf4a | Date: 9/4/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.32s (±106ms) 🟡 | historical mean value: 1.33s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 992ms (±103ms) 🟢 | historical mean value: 1.00s ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 97ms (±44ms) 🟢 | historical mean value: 101ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.32s 106ms 1.26s 1.89s 1.50s 1.89s
domContentLoaded 992ms 103ms 947ms 1.56s 1.16s 1.56s
firstPaint 97ms 44ms 72ms 304ms 224ms 304ms
firstContentfulPaint 97ms 44ms 72ms 304ms 224ms 304ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [24ce9a6]
UI Startup Metrics (1390 ± 92 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1390119317649214441556
load1195102215319112451365
domContentLoaded1185101515199312371356
domInteractive21154862337
firstPaint81084142547912221334
backgroundConnect28025243023286309
firstReactRender3117148163450
getState16687101830
initialActions617010718
loadScripts9147581222919661074
setupStore127108101218
WebpackHomeuiStartup20721544265224422342520
load16621234211419317731927
domContentLoaded16531222210119317671905
domInteractive181280141453
firstPaint1767158975201316
backgroundConnect3614331413256
firstReactRender91373256086308
getState2752905915219
initialActions62434811
loadScripts16491220209019217651893
setupStore1363851623
FirefoxBrowserifyHomeuiStartup13851189186211814401595
load1198104114168312581368
domContentLoaded1197104114168312581367
domInteractive1003430150105229
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3718410413582
firstReactRender26227362834
getState8312215626
initialActions7024025310
loadScripts1173102613897912321294
setupStore1046911827
WebpackHomeuiStartup15471316196913816111844
load13181136167511613951565
domContentLoaded13181136167511613951565
domInteractive100363025395263
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect311999103645
firstReactRender44367154652
getState63162611
initialActions5012613310
loadScripts12951119164411513701537
setupStore105136131016
Benchmark value 1390 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1196 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1185 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 21 exceeds gate value 20 for chrome browserify home mean domInteractive
Benchmark value 810 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 280 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 31 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 914 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 12 exceeds gate value 11 for chrome browserify home mean setupStore
Benchmark value 1556 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1365 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1357 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1335 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 309 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 50 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 1075 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2520 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 219 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 229 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 82 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 263 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 823ms | Sum of p95 exceeds: 1413.8ms
Sum of all benchmark exceeds: 2236.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.62 KiB (0.06%)
  • ui: 605 Bytes (0.01%)
  • common: 1.31 KiB (0.02%)

@david0xd david0xd added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 1d85b91 Sep 5, 2025
145 checks passed
@david0xd david0xd deleted the dd/multichain-account-search branch September 5, 2025 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2025
@metamaskbot metamaskbot added the release-13.4.0 Issue or pull request that will be included in release 13.4.0 label Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-13.4.0 Issue or pull request that will be included in release 13.4.0 size-M team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants