-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat: Add search functionality to the Multichain Account List page #35616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
387960d
to
d71bd4d
Compare
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (6 files, +315 -56)
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [d71bd4d]
UI Startup Metrics (1247 ± 69 ms)
Benchmark value 1078 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1068 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 249 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1376 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1218 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1211 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 970 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 38 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 210 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 100 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1675 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 118 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1407 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1965 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1692 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1692 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 300 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1671 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 559ms | Sum of p95 exceeds: 785.8ms Sum of all benchmark exceeds: 1344.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [ede1108]
UI Startup Metrics (1193 ± 59 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 7 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1418 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1687 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 245 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 88 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 47 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 261 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 287ms | Sum of p95 exceeds: 566.8ms Sum of all benchmark exceeds: 853.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Add search functionality and utils Handle edge case with no accounts
fdc3380
to
f800fec
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [f800fec]
UI Startup Metrics (1215 ± 82 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 41 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 286 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1431 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1241 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 244 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 88 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 265 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 320ms | Sum of p95 exceeds: 541.8ms Sum of all benchmark exceeds: 861.8ms |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [c87d1e8]
UI Startup Metrics (1201 ± 56 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 47 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 298 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1938 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1673 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1673 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 142 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 63 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 36 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1626 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 2181 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1895 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1894 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 386 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 142 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1863 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 71 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 256 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 2160ms | Sum of p95 exceeds: 2493.8ms Sum of all benchmark exceeds: 4653.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [b85f1eb]
UI Startup Metrics (1228 ± 73 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1211 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1204 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 256 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 960 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2249 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1793 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1782 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 1778 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2736 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2136 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2116 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 87 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2104 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 244 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 93 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 279 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 579ms | Sum of p95 exceeds: 1278.8ms Sum of all benchmark exceeds: 1857.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [24ce9a6]
UI Startup Metrics (1390 ± 92 ms)
Benchmark value 1196 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1185 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 21 exceeds gate value 20 for chrome browserify home mean domInteractive Benchmark value 810 exceeds gate value 800 for chrome browserify home mean firstPaint Benchmark value 280 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 31 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 914 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 12 exceeds gate value 11 for chrome browserify home mean setupStore Benchmark value 1556 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1365 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1357 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1335 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 309 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 50 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1075 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2520 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 219 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 37 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 229 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 82 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 263 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 823ms | Sum of p95 exceeds: 1413.8ms Sum of all benchmark exceeds: 2236.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR adds search functionality implementation for the Multichain Account List.
Notes:
Changelog
CHANGELOG entry: Added search functionality to the Multichain Account List
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-370
Manual testing steps
Screenshots/Recordings
Before
Search was not available before. Nothing to show here.
After
Screen.Recording.2025-09-04.at.12.28.57.mov
Pre-merge author checklist
Pre-merge reviewer checklist