-
Notifications
You must be signed in to change notification settings - Fork 396
Multilingual Support #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilingual Support #151
Conversation
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
1 similar comment
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
|
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
That didn't merge correctly, let me try again |
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
2 similar comments
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
Looks good! The language "icon" is a bit confusing though. Maybe take some from here? It feels that also it would look better right aligned (near or below the "Edit on Github" button). |
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
I know we had talked about the Edit on Github/Wiki button. Do we want to move that to the bottom while I am here? |
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
Maybe remove "edit on github" completely? For people not using github, it leads to 404 page, and who does, usually goes through the github repo as it's more familiar. |
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
Ahh, rebase time |
* In other langs, wasn't marking as active
73da024
to
f8f2bf9
Compare
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
Issues before merging:
|
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
We don't have translations for almost any page, so I am going to leave this for now. It is an easy fix if the site gets close to a full translation. |
🚀 Draft Preview: https://pr151-draft.lc0.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements multilingual support for the website, adding Spanish and Hindi translations with language-specific navigation, menus, and content. The implementation includes proper internationalization infrastructure for alert messages, navigation menus, and homepage content.
Key changes include:
- Introduction of language dropdown functionality for translated pages
- Implementation of fallback behavior for untranslated content in sidebar navigation
- Addition of Spanish and Hindi translations for FAQ page and homepage data
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
themes/leela/layouts/_partials/sidebar.html | Enhanced sidebar navigation with multilingual support and fallback to English content |
themes/leela/layouts/_partials/main-menu.html | Added internationalization for menu item names using translation keys |
themes/leela/layouts/_partials/i18n-dropdown.html | New language selector dropdown component for translated pages |
themes/leela/layouts/_partials/head/opengraph.html | Added multilingual SEO optimization with hreflang tags |
themes/leela/layouts/_partials/content.html | Integrated language dropdown and machine translation notice banner |
themes/leela/layouts/_markup/render-blockquote.html | Implemented internationalized alert titles with fallback handling |
themes/leela/assets/js/main.js | Added JavaScript functionality for language dropdown toggle behavior |
themes/leela/assets/css/main.css | Added styling for language dropdown component |
themes/leela/assets/css/icons.css | Added language icon for dropdown toggle button |
layouts/index.html | Updated homepage to support language-specific data files |
i18n/*.toml | Created translation files for English, Spanish, and Hindi UI strings |
data/*/homepage.json | Added Spanish and Hindi translations for homepage content |
content/play/faq.es.md | Spanish translation of FAQ page |
content/play/_index.es.md | Spanish section index page |
content/contribute/hugo/translate.md | Updated translation documentation with detailed instructions |
config.toml | Added multilingual configuration and menu identifiers |
README.md | Added development setup and translation guidelines |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This is my first attempt at multilingual support, only
/play/faq/
has a translation.Note: The list of languages at the top of pages with translations is going to change.
Closes #8