feat: Improve wording for Security Whitelist Error Message [INS-1277] #9076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaodemen
force-pushed
the
feat/access-file
branch
2 times, most recently
from
bda8fac to
7cecfc6
Compare
jackkav
reviewed
Sep 2, 2025
| @@ -136,11 +140,29 @@ export const RenderedQueryString: FC<Props> = ({ request }) => { | |||
| } | |||
| }, [tooLong]); | |||
|
|
|||
| const showPreferneces = useCallback(() => { | |||
There was a problem hiding this comment.
Suggested change
| const showPreferneces = useCallback(() => { | |
| const showPreferences = useCallback(() => { |
it is preferable just to inline a state setter like this to the markup below, saves a bunch reading for the next guy for almost no perf benefit.
xiaodemen
force-pushed
the
feat/access-file
branch
3 times, most recently
from
3ff3705 to
afd4a45
Compare
ihexxa
previously approved these changes
Sep 3, 2025
|
|
||
| return ( | ||
| <div className="relative flex h-full w-full justify-between gap-[var(--padding-sm)] overflow-auto"> | ||
| <span className={classNames('my-auto', className)}>{previewString}</span> | ||
| <span className={classNames('my-auto', className)}> | ||
| {messages.map(({ text, handler }, index) => |
There was a problem hiding this comment.
nit: is it good to introduce a generic component which could be a string or Link? Then we don't need condition check in every places.
xiaodemen
force-pushed
the
feat/access-file
branch
from
afd4a45 to
ae10d6c
Compare
cwangsmv
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes INS-1277