Skip to content

Update ESPAsyncHTTPUpdateServer.cpp #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ESPAsyncHTTPUpdateServer.cpp #32

wants to merge 1 commit into from

Conversation

GitHubLionel
Copy link

Some improvements:

make a compromise: use Ticker only for ESP8266, use native task for ESP32
_updateType and _updateResult initialized in constructor to avoid compiler warning
_updateType and _updateResult should be initialised only one time in the if (!index) condition
replace comparison to emptystring by isEmpty()
set (void) filename; to avoid compiler warning

@GitHubLionel
Update ESPAsyncHTTPUpdateServer.cpp
992605e 
Some improvements:

    make a compromise: use Ticker only for ESP8266, use native task for ESP32
    _updateType and _updateResult initialized in constructor to avoid compiler warning
    _updateType and _updateResult should be initialised only one time in the if (!index) condition
    replace comparison to emptystring by isEmpty()
    set (void) filename; to avoid compiler warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GitHubLionel