-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(genai): Add samples for vertexAI express mode api key #5376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces new sample code for the Google Cloud Generative AI (GenAI) SDK. The primary purpose of these changes is to demonstrate how to utilize Vertex AI's express mode by authenticating with an API key. This provides developers with a clear example of how to interact with GenAI models using a direct API key authentication method, expanding the available authentication patterns for the SDK.
Highlights
- New Vertex AI Express Mode Sample: A new Go file,
expressmode_with_api_key.go
, has been added. This file contains thegenerateContentWithApiKey
function, which demonstrates how to initialize thegenai.Client
with an API key and make aGenerateContent
call to a Gemini model, specifically "gemini-2.5-flash". - Integration Test for API Key Sample: A corresponding test file,
expressmode_with_api_key_test.go
, has been introduced to validate the functionality of the new sample. This integration test sets up necessary environment variables for Vertex AI and verifies that thegenerateContentWithApiKey
function produces non-empty output, skipping the test if the required API key is not configured.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new Go sample for using Vertex AI Express Mode with an API key. The changes are a good start, but there are a few critical issues in both the sample code and the test that need to be addressed. The main issues are related to Go naming conventions, incorrect handling of the API key which makes the sample and test non-functional, and a missing documentation tag. I've left specific comments with suggestions to fix these problems.
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
…into genai-vertex-api-key
Description
Mock test for local testing and so avoid api calls
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)