RND-7985: accessible search #3637
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 960ccc2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
clairechabas
approved these changes
Sep 10, 2025
Comment on lines
240
to
243
| resultsShowing={resultsState.showing} | ||
| resultsCount={resultsState.count} | ||
| cursor={resultsState.cursor} | ||
| controlsId={searchResultsId} |
There was a problem hiding this comment.
Just a suggestion: I think it could be more readable to keep a resultsState object throughout instead of spreading it :
Suggested change
| resultsShowing={resultsState.showing} | |
| resultsCount={resultsState.count} | |
| cursor={resultsState.cursor} | |
| controlsId={searchResultsId} | |
| resultsState={resultsState} | |
| controlsId={searchResultsId} |
Comment on lines
19
to
21
| resultsCount: number; | ||
| cursor: number | null; | ||
| resultsShowing: boolean; |
There was a problem hiding this comment.
Following up my suggestion above:
Suggested change
| resultsCount: number; | |
| cursor: number | null; | |
| resultsShowing: boolean; | |
| resultsState: ResultsState; |
Comment on lines
164
to
168
| const [resultsState, setResultsState] = React.useState<{ | ||
| count: number; | ||
| showing: boolean; | ||
| cursor: number | null; | ||
| }>({ |
There was a problem hiding this comment.
Following up my suggestion below:
Suggested change
| const [resultsState, setResultsState] = React.useState<{ | |
| count: number; | |
| showing: boolean; | |
| cursor: number | null; | |
| }>({ | |
| const [resultsState, setResultsState] = React.useState<ResultsState>({ |
And the type would live above:
type ResultsState = {
count: number;
showing: boolean;
cursor: number | null;
}
Comment on lines
104
to
105
| {resultsShowing | ||
| ? resultsCount > 0 |
There was a problem hiding this comment.
and :
Suggested change
| {resultsShowing | |
| ? resultsCount > 0 | |
| {resultsState.showing | |
| ? resultsState.count > 0 |
Comment on lines
37
to
39
| resultsCount, | ||
| resultsShowing, | ||
| cursor, |
There was a problem hiding this comment.
Suggested change
| resultsCount, | |
| resultsShowing, | |
| cursor, | |
| resultsState |
clairechabas
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues around search accessibility: