Skip to content

[Reviewed] [3D particles] Fix the rotation around X axis to be the other way #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Reviewed] [3D particles] Fix the rotation around X axis to be the other way #1724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c6c7b
[Reviewed] [3D particles] Fix the rotation around X axis to be the ot…
D8H Jul 7, 2025
1e7a716
Add a default size
D8H Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions extensions/reviewed/ParticleEmitter3D.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"name": "ParticleEmitter3D",
"previewIconUrl": "https://asset-resources.gdevelop.io/public-resources/Icons/f2e5a34bf465f781866677762d385d6c8e9e8d203383f2df9a3b7e0fad6a2cb5_fire.svg",
"shortDescription": "Display a large number of particles in 3D to create visual effects in a 3D game.",
"version": "2.2.0",
"version": "3.0.0",
"description": [
"3D particle emitters let you create and display many small particles to simulate visual effects in your game — like fire, explosions, smoke, or dust.",
"",
Expand All @@ -34,6 +34,10 @@
"IWykYNRvhCZBN3vEgKEbBPOR3Oc2"
],
"changelog": [
{
"version": "3.0.0",
"breaking": "- the object rotate the other way around X axis."
},
{
"version": "2.0.0",
"breaking": "- Object properties for position and rotation have been removed. They must be set with the instance editor or the action."
Expand Down Expand Up @@ -77,9 +81,7 @@
" const threeObject3D = this.get3DRendererObject();",
"",
" threeObject3D.rotation.set(",
" // TODO The rotation on X goes the wrong way.",
" // Increment the major and remove this sign.",
" - gdjs.toRad(this._object.getRotationX()),",
" gdjs.toRad(this._object.getRotationX()),",
" gdjs.toRad(this._object.getRotationY()),",
" gdjs.toRad(this._object.angle)",
" );",
Expand Down Expand Up @@ -6993,6 +6995,15 @@
"",
"/** @type {gdjs.CustomRuntimeObject} */",
"const object = objects[0];",
"// Force the size of the object because it doesn't contain any instance.",
"object._innerArea = {",
" min: [-16, -16, -16],",
" max: [16, 16, 16],",
" };",
"const hitbox = new gdjs.Polygon();",
"hitbox.vertices = [[-16, -16], [16, -16], [16, 16], [-16, 16]];",
"object._untransformedHitBoxes = [hitbox];",
"object._updateUntransformedHitBoxes = () => {};",
"",
"// Here runtimeScene is the gdjs.CustomRuntimeObjectInstanceContainer inside the custom object.",
"const gameScene = object.getRuntimeScene();",
Expand Down