Fixes clipping/loss of interactivity bug in VictoryCursorContainer (#3063) #3064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3063
Previously, victory-native/victory-cursor-container spread the result of useVictoryCursorContainer into VictoryContainer
Where the return type of useVictoryZoomContainer is
Because VictoryContainer received the entire props object as a prop, instead of spreading its properties, values such as width and height were undefined - leading to the svg element to render with undefined values in its viewBox, e.g.
thus clipping the rendered chart and brokes the functionality of this container.
Fix based on following PR #3026
Type of Change
How Has This Been Tested?
To the react-native/demo new screen was added for manual testing.
Checklist: (Feel free to delete this section upon completion)