feat: add new Handler kwarg multiprocessing_queue
#1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, will enqueue messages to a queue.Queue instance
injust
reviewed
May 6, 2025
| @@ -377,7 +382,11 @@ class Logger: | |||
| def exception(__self, __message: Any) -> None: ... # noqa: N805 | |||
| @overload | |||
| def log( | |||
| __self, __level: Union[int, str], __message: str, *args: Any, **kwargs: Any # noqa: N805 | |||
| __self, | |||
There was a problem hiding this comment.
The noqa: N805 comment should go on the __self line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This controls whether to enqueue messages to a multiprocessing-safe queue or a simple queue. If the user knows the program will never spawn child processes, settings this option to False may reduce the enqueue overhead.
BTW: for some reason the ruff linter insists on breaking up line 385 in init.pyi which misplaces the required "noqa: N805" rule on this line... I had to ignore the ruff rule in pre-commit for now until I figure out what went wrong 😑