-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Implement NowSecure parser #13084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Implement NowSecure parser #13084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Left some comments to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved besides the recommencations from valentinscholten.
…es for resilience and modified unittests accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make all access to the json object safe using get()
…in favour of more resilient methods
Thank you. Could you look at the failed tests? |
Description
New parser for NowSecure app analysis results.
Test results
Tested basic parsing functionality for no vulns, one vuln and many vulns. Unittest added on the appropriate folder.
Documentation
Documentation has been updated on: documentation folder