Skip to content

Conversation

30vh1
Copy link

@30vh1 30vh1 commented Sep 1, 2025

Description

New parser for NowSecure app analysis results.

Test results

Tested basic parsing functionality for no vulns, one vuln and many vulns. Unittest added on the appropriate folder.

Documentation

Documentation has been updated on: documentation folder

@30vh1 30vh1 requested a review from manuel-sommer September 1, 2025 14:47
Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Left some comments to consider.

Copy link
Contributor

@manuel-sommer manuel-sommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved besides the recommencations from valentinscholten.

…es for resilience and modified unittests accordingly
Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make all access to the json object safe using get()

@valentijnscholten
Copy link
Member

Thank you. Could you look at the failed tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants