-
Notifications
You must be signed in to change notification settings - Fork 8.5k
feat(route/discord): render Markdown to HTML #19653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LucunJi
wants to merge
5
commits into
DIYgod:master
Choose a base branch
from
LucunJi:contribute
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- render Markdown to HTML, including Markdowns in content and embeds - the title extracted from content is also rendered - add dependencies: discord-markdown-parser, @khanacademy/simple-markdown - improve template with - better spacing, - rendered embed fields, - spoiler for attachments with SPOILER_ prefix. - misc including - using embed title as message title, if there is no content, - list is not parsed cuz it's not supported in discord-markdown-parser, I may add support for it in the future - not rigorously tested as this is not generally reviewed
Successfully generated as following: http://localhost:1200/discord/channel/0 - Failed ❌
|
Successfully generated as following: http://localhost:1200/discord/channel/0 - Failed ❌
|
TonyRL
reviewed
Jul 22, 2025
.join(' / '); | ||
} | ||
|
||
title = mdFormatter.parse(title); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may causes the title to include HTML. title
is expected to have plain text only.
Successfully generated as following: http://localhost:1200/discord/channel/0 - Failed ❌
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto: not ready to review
core enhancement
dependencies
This PR involves changes to dependencies
route: deprecated
route
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discord-markdown-parser
,@khanacademy/simple-markdown
SPOILER_
prefix.Involved Issue / 该 PR 相关 Issue
N/A
Example for the Proposed Route(s) / 路由地址示例
(it should fail without proper
DISCORD_AUTHORIZATION
)New RSS Route Checklist / 新 RSS 路由检查表
Puppeteer
Note / 说明