-
Notifications
You must be signed in to change notification settings - Fork 427
feat: Support direct material property assignment from JSON params #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Extended ApplyMaterialProperties to loop through all properties in the provided JObject and set them directly on the material if they match a known property (e.g., _Color, _MainTex, etc.). Now supports direct assignment of color, float, and texture properties using simple JSON structures, such as: { "_Color": [0, 1, 0, 1] } for albedo color { "_Glossiness": 0.5 } for smoothness { "_MainTex": "Assets/Textures/MyTex.png" } for textures Retained backward compatibility with the previous structured property format (color, float, texture objects). This change enables more flexible and user-friendly material creation and modification via automation and external tools. Fixes issues where material color and other properties could not be set from automation.
- Modified ServerInstaller.cs to download from KlausUllrich/unity-mcp - This ensures Unity package installs code from our fork, not original repo - Critical for testing our audited code improvements - Part of AWMS Unity MCP testing strategy
- Add fork identification and enhancements section - Update installation URL to use KlausUllrich/unity-mcp - Add note about ServerInstaller enhancement - Include AWMS project integration information - Add references to enhanced documentation and testing - Acknowledge original project by justinpbarnett
…allation - Modified ServerInstaller.GetSaveLocation() to prioritize repository path - Eliminates double installation conflicts between Unity Bridge and Claude Desktop - Removes AppData hardcoded path dependency - Maintains backward compatibility with fallback to AppData - Fixes MCP Editor server detection and port display issues
- Document installation path fix implementation - Confirm Unity MCP Bridge and Python server status - Outline testing requirements for material property validation - Prepare for systematic Unity MCP tool validation
- Analyzed active Unity MCP forks: IvanMurzak, nurture-tech, CoderGamester - Integrated justinpbarnett original roadmap priorities - Prioritized improvements for AWMS integration - Strategic focus: enhanced error handling, custom tools, context reduction - Implementation phases aligned with AWMS development timeline
- Added concise session knowledge for Unity MCP issues - Documents current problems: material properties, editor tool, testing - References AWMS validation framework in Unity_AWMS_Test
Sounds cool! I saw the doc you made and wonder what was the possible issue with properties set but not applied? |
Hi again @KlausUllrich. Not sure if you're still interested in working on this PR. If not, we'll close. If so, here are some notes: There's a useful feature in here, but the PR mixes unrelated changes. |
Hey @KlausUllrich, I know it's been a while but we'd love to have this feature in. Let us know if you're still keen and need any further support. Great work so far! |
Uff, hello guys, I am really sorry for my slow response times! I am still traveling and won't be back withing the next 3 weeks. If possible, can you take over? Busy times... I am sorry! |
No need to apologize! Please enjoy your travels |
Extended ApplyMaterialProperties to loop through all properties in the provided JObject and set them directly on the material if they match a known property (e.g., _Color, _MainTex, etc.). Now supports direct assignment of color, float, and texture properties using simple JSON structures, such as: { "_Color": [0, 1, 0, 1] } for albedo color
{ "_Glossiness": 0.5 } for smoothness
{ "_MainTex": "Assets/Textures/MyTex.png" } for textures Retained backward compatibility with the previous structured property format (color, float, texture objects). This change enables more flexible and user-friendly material creation and modification via automation and external tools. Fixes issues where material color and other properties could not be set from automation.