Skip to content

sp_Blitz: Linux quality improvements #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

sp_Blitz: Linux quality improvements #3707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sp_Blitz.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5013,7 +5013,7 @@ IF @ProductVersionMajor >= 10
END;
END;
/* CheckID 258 - Security - SQL Server Service is running as LocalSystem or NT AUTHORITY\SYSTEM */
IF @ProductVersionMajor >= 10
IF (@ProductVersionMajor >= 10 AND @IsWindowsOperatingSystem = 1)
AND NOT EXISTS ( SELECT 1
FROM #SkipChecks
WHERE DatabaseName IS NULL AND CheckID = 258 )
Expand Down Expand Up @@ -5050,7 +5050,7 @@ IF @ProductVersionMajor >= 10
END;

/* CheckID 259 - Security - SQL Server Agent Service is running as LocalSystem or NT AUTHORITY\SYSTEM */
IF @ProductVersionMajor >= 10
IF (@ProductVersionMajor >= 10 AND @IsWindowsOperatingSystem = 1)
AND NOT EXISTS ( SELECT 1
FROM #SkipChecks
WHERE DatabaseName IS NULL AND CheckID = 259 )
Expand Down Expand Up @@ -5123,7 +5123,7 @@ IF @ProductVersionMajor >= 10
END;

/*This checks which service account SQL Server is running as.*/
IF @ProductVersionMajor >= 10
IF (@ProductVersionMajor >= 10 AND @IsWindowsOperatingSystem = 1)
AND NOT EXISTS ( SELECT 1
FROM #SkipChecks
WHERE DatabaseName IS NULL AND CheckID = 169 )
Expand Down Expand Up @@ -5163,7 +5163,7 @@ IF @ProductVersionMajor >= 10
END;

/*This checks which service account SQL Agent is running as.*/
IF @ProductVersionMajor >= 10
IF (@ProductVersionMajor >= 10 AND @IsWindowsOperatingSystem = 1)
AND NOT EXISTS ( SELECT 1
FROM #SkipChecks
WHERE DatabaseName IS NULL AND CheckID = 170 )
Expand Down Expand Up @@ -9233,7 +9233,7 @@ IF @ProductVersionMajor >= 10 AND NOT EXISTS ( SELECT 1
''Server Info'' AS FindingsGroup ,
''Services'' AS Finding ,
'''' AS URL ,
N''Service: '' + servicename + N'' runs under service account '' + service_account + N''. Last startup time: '' + COALESCE(CAST(CASE WHEN YEAR(last_startup_time) <= 1753 THEN CAST(''17530101'' as datetime) ELSE CAST(last_startup_time AS DATETIME) END AS VARCHAR(50)), ''not shown.'') + ''. Startup type: '' + startup_type_desc + N'', currently '' + status_desc + ''.''
N''Service: '' + servicename + ISNULL((N'' runs under service account '' + service_account),'''') + N''. Last startup time: '' + COALESCE(CAST(CASE WHEN YEAR(last_startup_time) <= 1753 THEN CAST(''17530101'' as datetime) ELSE CAST(last_startup_time AS DATETIME) END AS VARCHAR(50)), ''not shown.'') + ''. Startup type: '' + startup_type_desc + N'', currently '' + status_desc + ''.''
FROM sys.dm_server_services OPTION (RECOMPILE);';

IF @Debug = 2 AND @StringToExecute IS NOT NULL PRINT @StringToExecute;
Expand Down