-
Notifications
You must be signed in to change notification settings - Fork 62
Refactor Zone Creation [AARD-2071]
#1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexD717
wants to merge
12
commits into
dev
Choose a base branch
from
alexey/2071/refactor-zone-creation
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutmanz
requested changes
Aug 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Turning on persistent points for a scoring zone or either dropdown for protected zones seems to reset the position and scale
- The red material for scoring zones get blocked by objects in front but the blue does not (I think it's better if they're both occluded because it makes it easier to position things)
- It's not strictly in scope but the buttons being down below in the main menu is kind of weird and it might make sense to fix as part of this
...rc/ui/panels/configuring/assembly-config/interfaces/scoring/ProtectedZoneConfigInterface.tsx
Outdated
Show resolved
Hide resolved
...src/ui/panels/configuring/assembly-config/interfaces/scoring/ManageScoringZonesInterface.tsx
Outdated
Show resolved
Hide resolved
...c/ui/panels/configuring/assembly-config/interfaces/scoring/ManageProtectedZonesInterface.tsx
Outdated
Show resolved
Hide resolved
.../src/ui/panels/configuring/assembly-config/interfaces/scoring/ScoringZoneConfigInterface.tsx
Outdated
Show resolved
Hide resolved
.../src/ui/panels/configuring/assembly-config/interfaces/scoring/ScoringZoneConfigInterface.tsx
Outdated
Show resolved
Hide resolved
rutmanz
reviewed
Aug 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
rutmanz
reviewed
Aug 18, 2025
rutmanz
reviewed
Aug 18, 2025
rutmanz
approved these changes
Aug 19, 2025
ryanzhangofficial
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Refactor the way zones are created in synthesis.
AARD-2071
Symptom
There is currently a lot of duplicate code in the way Scoring Zones and Protected Zones are set up. If we decide that we want to add more zones later, ex for a loading station zone (AARD-2072) there would be even more duplicate code.
Solution
Move the code that is the same for all zones, such as the name, and mainly gizmo configuration into an outside component, making it easier to add more zones later in the future.
Verification
Before merging, ensure the following criteria are met: