Skip to content

Conversation

AlexD717
Copy link
Member

Task

Refactor the way zones are created in synthesis.

AARD-2071

Symptom

There is currently a lot of duplicate code in the way Scoring Zones and Protected Zones are set up. If we decide that we want to add more zones later, ex for a loading station zone (AARD-2072) there would be even more duplicate code.

Solution

Move the code that is the same for all zones, such as the name, and mainly gizmo configuration into an outside component, making it easier to add more zones later in the future.

Verification

  • All current zone related functionality still works

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Aug 15, 2025
@AlexD717 AlexD717 added the refactor The most important part of software development. label Aug 15, 2025
@AlexD717 AlexD717 marked this pull request as ready for review August 15, 2025 16:17
@AlexD717 AlexD717 requested review from a team as code owners August 15, 2025 16:17
Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Turning on persistent points for a scoring zone or either dropdown for protected zones seems to reset the position and scale
  • The red material for scoring zones get blocked by objects in front but the blue does not (I think it's better if they're both occluded because it makes it easier to position things)
  • It's not strictly in scope but the buttons being down below in the main menu is kind of weird and it might make sense to fix as part of this

@AlexD717 AlexD717 requested a review from rutmanz August 15, 2025 19:51
Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@AlexD717 AlexD717 requested a review from rutmanz August 18, 2025 22:23
@AlexD717 AlexD717 requested a review from rutmanz August 19, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor The most important part of software development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants