Skip to content

Commit 8e67e32

Browse files
committed
v2.6 - Improve sanitization per Issue #4
-v2.6. -Improve sanitization per Issue #4. -Github user @robre pointed out some typos in sanitizeCore.php, specifically lines 95 & line 96 from v2.4. -These bugs mean to me that I need to review more of this code. -Thank you, @robre!
1 parent 5cf72aa commit 8e67e32

File tree

4 files changed

+14
-4
lines changed

4 files changed

+14
-4
lines changed

CHANGELOG.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
COMMIT - 2/11/2020
2+
v2.6 - Improve sanitization per Issue #4.
3+
4+
-v2.6.
5+
-Improve sanitization per Issue #4.
6+
-Github user @robre pointed out some typos in sanitizeCore.php, specifically lines 95 & line 96 from v2.4.
7+
-These bugs mean to me that I need to review more of this code.
8+
-Thank you, @robre!
9+
10+
--------------------
111
COMMIT 11/18/2018
212
v2.4 - Improve sanitization.
313

convertCore.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151

5252
// / -----------------------------------------------------------------------------------
5353
// / The following code sets the global variables for the session.
54-
$HRConvertVersion = 'v2.5';
54+
$HRConvertVersion = 'v2.6';
5555
$Date = date("m_d_y");
5656
$Time = date("F j, Y, g:i a");
5757
$JanitorFile = 'janitor.php';

sanitizeCore.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@
9292
// / Must specify $_POST['filesToDownload'] as a string or an array of filenames in the CloudLoc.
9393
if (isset($_POST['download'])) {
9494
$download = htmlentities(str_replace('..', '', str_replace(str_split('~#[]{};:$!#^&%@>*<|'), '', $_POST['download'])), ENT_QUOTES, 'UTF-8');
95-
if (isset($_POST['filesToUpload'])) {
96-
$_POST['filesToDownload'] = htmlentities(sstr_replace('..', '', tr_replace(str_split('\\/~#[]{};:$!#^&%@>*<|"\''), '', $_POST['filesToDownload'])), ENT_QUOTES, 'UTF-8');
95+
if (isset($_POST['filesToDownload'])) {
96+
$_POST['filesToDownload'] = htmlentities(str_replace('..', '', str_replace(str_split('\\/~#[]{};:$!#^&%@>*<|"\''), '', $_POST['filesToDownload'])), ENT_QUOTES, 'UTF-8');
9797
if (!is_array($_POST['filesToDownload'])) {
9898
$_POST['filesToDownload'] = array($_POST['filesToDownload']);
9999
$_POST['filesToDownload'] = htmlentities(str_replace('..', '', str_replace(str_split('~#[]{};:$!#^&%@>*<|"\''), '', $_POST['filesToDownload'])), ENT_QUOTES, 'UTF-8'); } } }

versionInfo.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?php
22
// / This file contains the current HRConvert2 version for auto-update purposes.
33

4-
$Version = 'v2.5';
4+
$Version = 'v2.6';

0 commit comments

Comments
 (0)