Receivership entities appear twice in Entity view

[perwestling]

A corporation in receivership appears twice under Bank.

What's your Game ID?

I believe this is a general issue, but I did encounter it during play test of a new title.

How to Reproduce the Bug?

Set a corporation into receivership.
Go to Entity tab.

Which Browser / Platform?

N/A

Likely source of problem

In entity.rb (view) the following code renders the corporations:

extra_bank = []
if @game.respond_to?(:unstarted_corporation_summary)
  others = @game.unstarted_corporation_summary.last
  extra_bank.concat(others.map { |c| h(Corporation, corporation: c) })
else
  extra_bank.concat(bank_owned.map { |c| h(Corporation, corporation: c) })
end
children << h(:div, [
  h(Bank, game: @game),
  h(GameInfo, game: @game, layout: 'upcoming_trains'),
  *@game.unowned_purchasable_companies(@current_entity).map { |company| h(Company, company: company) },
  *@game.receivership_corporations.map { |c| h(Corporation, corporation: c) },
  *extra_bank,
].compact)

The base implementation of receivership_corporations is just to select all corporations that is in receivership.
At the same time all corporations are split into player_owned and bank_owned. Therefor the corporation appear in two places, giving the duplication.

[perwestling]

As a workaround (in 1824 2-player - bond railway) I implemented receivership_corporations to just return an empty list, as that method is only used in this view.
This method is only overridden in 1841, but after checking a few games of 1841, I did not see any duplicates.

So I put this here, and in case it does appear in some other title it might need to be fixed properly.