feat: async SSR #16748
Merged
feat: async SSR #16748
+2,638
−901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undary-error-message
This reverts commit 3ec461b.
Rich-Harris
reviewed
Sep 17, 2025
…velte into adjust-boundary-error-message
Ocean-OS
reviewed
Sep 17, 2025
packages/svelte/src/compiler/phases/3-transform/server/visitors/AwaitExpression.js
Show resolved
Hide resolved
| const left = b.id('$$payload.select_value'); | ||
|
|
||
| if (value.type === 'Attribute' && value.value !== true) { | ||
| select_with_value_async ||= (Array.isArray(value.value) ? value.value : [value.value]).some( |
There was a problem hiding this comment.
Suggested change
| select_with_value_async ||= (Array.isArray(value.value) ? value.value : [value.value]).some( | |
| select_with_value_async ||= [value.value].flat().some( |
There was a problem hiding this comment.
eh the existing version is marginally more efficient and tbh both of them are extremely confusing to me so I'll go with the more efficient version 😆
Rich-Harris
reviewed
Sep 17, 2025
Rich-Harris
reviewed
Sep 17, 2025
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint