Skip to content

Commit cf367de

Browse files
committed
feat: change versionlog function to be more clear
feat: changed commit text feat: added a comment to be more clear in commit options
1 parent db0434a commit cf367de

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

scripts/common/constants.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
export const PUBLISH_COMMIT_SUBJECT = 'chore(release): publish';
33
export const NPM_ORG_NAME = '@rango-dev';
44
export const BUILD_META_FILE_SUFFIX = '.build.json';
5-
export const ROOT_VERSIONS_COMMIT_SUBJECT = 'chore(release): root versions and changelog';
5+
export const ROOT_VERSIONS_COMMIT_SUBJECT =
6+
'chore(release): bump the repo and client versions';

scripts/publish/command.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { addFileToStage, publishCommitAndTags, push } from '../common/git.mjs';
1616
import { update } from './package.mjs';
1717
import { build } from './build.mjs';
1818
import { should } from '../common/features.mjs';
19-
import { versionLog } from './version-log.mjs';
19+
import { bumpClientAndRootVersionsAndGenerateRootChangelog } from './version-log.mjs';
2020

2121
async function run() {
2222
logAsSection('::group::🔍 Checking environments...');
@@ -66,7 +66,7 @@ async function run() {
6666

6767
// 2. Generate root changelog and bump widget, app and root versions.
6868
logAsSection('::group::📋 Root changelog and versions...');
69-
await versionLog();
69+
await bumpClientAndRootVersionsAndGenerateRootChangelog();
7070
console.log('::endgroup::');
7171

7272
// 3. Build all packacges

scripts/publish/version-log.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ async function bumpVersions() {
3737
await addFileToStage(packageJsonPath(playgroundPackage.location));
3838
}
3939

40-
export async function versionLog() {
40+
export async function bumpClientAndRootVersionsAndGenerateRootChangelog() {
4141
if (should('generateChangelog')) {
4242
console.log(chalk.green('[1/3]'), `Bump versions`);
4343
await bumpVersions();
@@ -48,6 +48,7 @@ export async function versionLog() {
4848
console.log(chalk.green('[3/3]'), `Commit changes`);
4949
await makeCommit([ROOT_VERSIONS_COMMIT_SUBJECT], {
5050
shouldSkipCI: true,
51+
// If ESLint fails, it will break our workflow, so it has been turned off to avoid checking files.
5152
shouldVerify: false,
5253
});
5354
} else {

0 commit comments

Comments
 (0)