Do not accept SSL connection parameters when SSL is disabled

Author: pali

dbdimp.c

@@ -1679,6 +1679,17 @@ static bool mariadb_dr_connect(
         HV* processed = newHV();
         HE* he;
         SV** svp;
+        size_t i;
+
+        const char * const mariadb_ssl_attributes[] = {
+          "mariadb_ssl_optional",
+          "mariadb_ssl_verify_server_cert",
+          "mariadb_ssl_client_key",
+          "mariadb_ssl_client_cert",
+          "mariadb_ssl_ca_file",
+          "mariadb_ssl_ca_path",
+          "mariadb_ssl_cipher",
+        };
 
         sv_2mortal(newRV_noinc((SV *)processed)); /* Automatically free HV processed */
 
@@ -2054,13 +2065,8 @@ static bool mariadb_dr_connect(
                         imp_dbh->disable_fallback_for_server_prepare ? 1 : 0);
 
         (void)hv_stores(processed, "mariadb_ssl", &PL_sv_yes);
-        (void)hv_stores(processed, "mariadb_ssl_optional", &PL_sv_yes);
-        (void)hv_stores(processed, "mariadb_ssl_verify_server_cert", &PL_sv_yes);
-        (void)hv_stores(processed, "mariadb_ssl_client_key", &PL_sv_yes);
-        (void)hv_stores(processed, "mariadb_ssl_client_cert", &PL_sv_yes);
-        (void)hv_stores(processed, "mariadb_ssl_ca_file", &PL_sv_yes);
-        (void)hv_stores(processed, "mariadb_ssl_ca_path", &PL_sv_yes);
-        (void)hv_stores(processed, "mariadb_ssl_cipher", &PL_sv_yes);
+        for (i = 0; i < sizeof(mariadb_ssl_attributes)/sizeof(*mariadb_ssl_attributes); i++)
+          (void)hv_store(processed, mariadb_ssl_attributes[i], strlen(mariadb_ssl_attributes[i]), &PL_sv_yes, 0);
 	if ((svp = hv_fetchs(hv, "mariadb_ssl", FALSE)) && *svp && SvTRUE(*svp))
           {
 	    char *client_key = NULL;
@@ -2254,6 +2260,16 @@ static bool mariadb_dr_connect(
 	  }
 	else
 	  {
+	    for (i = 0; i < sizeof(mariadb_ssl_attributes)/sizeof(*mariadb_ssl_attributes); i++)
+	      {
+	        if ((svp = hv_fetch(hv, mariadb_ssl_attributes[i], strlen(mariadb_ssl_attributes[i]), FALSE)) && *svp)
+	          {
+	            mariadb_dr_do_error(dbh, CR_SSL_CONNECTION_ERROR, SvPVX(sv_2mortal(newSVpvf("SSL connection error: SSL attribute %s was specified but SSL encryption was not enabled via mariadb_ssl=1", mariadb_ssl_attributes[i]))), "HY000");
+	            mariadb_db_disconnect(dbh, imp_dbh);
+	            return FALSE;
+	          }
+	      }
+
 #ifdef HAVE_SSL_MODE
 	    unsigned int ssl_mode = SSL_MODE_DISABLED;
 	    mysql_options(sock, MYSQL_OPT_SSL_MODE, &ssl_mode);

lib/DBD/MariaDB.pod

@@ -294,6 +294,8 @@ When set MariaDB or MySQL server certificate is checked that it is signed by
 some CA certificate in the list. I<Common Name> value is not verified unless
 L<I<mariadb_ssl_verify_server_cert>|/mariadb_ssl_verify_server_cert> is enabled.
 
+Requires L<C<mariadb_ssl=1>|/mariadb_ssl>.
+
 =item mariadb_ssl_ca_path
 
 The path to a directory that contains trusted SSL certificate authority
@@ -306,6 +308,8 @@ L<I<mariadb_ssl_verify_server_cert>|/mariadb_ssl_verify_server_cert> is enabled.
 Please note that this option is supported only if your MariaDB or MySQL client
 was compiled with OpenSSL library, and not with default yaSSL library.
 
+Requires L<C<mariadb_ssl=1>|/mariadb_ssl>.
+
 =item mariadb_ssl_verify_server_cert
 
 Checks the server's I<Common Name> value in the certificate that the server
@@ -316,16 +320,22 @@ attacks.
 
 Verification of the host name is disabled by default.
 
+Requires L<C<mariadb_ssl=1>|/mariadb_ssl>.
+
 =item mariadb_ssl_client_key
 
 The name of the SSL key file in PEM format to use for establishing a secure
 connection.
 
+Requires L<C<mariadb_ssl=1>|/mariadb_ssl>.
+
 =item mariadb_ssl_client_cert
 
 The name of the SSL certificate file in PEM format to use for establishing a
 secure connection.
 
+Requires L<C<mariadb_ssl=1>|/mariadb_ssl>.
+
 =item mariadb_ssl_cipher
 
 A list of permissible ciphers to use for connection encryption. If no cipher in
@@ -334,6 +344,8 @@ the list is supported, encrypted connections will not work.
   mariadb_ssl_cipher=AES128-SHA
   mariadb_ssl_cipher=DHE-RSA-AES256-SHA:AES128-SHA
 
+Requires L<C<mariadb_ssl=1>|/mariadb_ssl>.
+
 =item mariadb_ssl_optional
 
 Setting I<mariadb_ssl_optional> to true disables strict SSL enforcement and
@@ -350,6 +362,8 @@ could refuse connection to MariaDB or MySQL server if underlying libmariadb or
 libmysqlclient library is vulnerable. Option I<mariadb_ssl_optional> can be used
 to make SSL connection vulnerable.
 
+Requires L<C<mariadb_ssl=1>|/mariadb_ssl>.
+
 =item mariadb_local_infile
 
 The C<LOCAL> capability for C<LOAD DATA> may be disabled in the MariaDB or MySQL