repl: prevent unwanted autocompletion on pressing Enter

Author: piotrzarycki

lib/internal/repl/utils.js

@@ -207,11 +207,6 @@ function setupPreview(repl, contextSymbol, bufferSymbol, active) {
           if (escaped === null && key.meta) {
             escaped = repl.line;
           }
-        } else if ((key.name === 'return' || key.name === 'enter') &&
-                   !key.meta &&
-                   escaped !== repl.line &&
-                   isCursorAtInputEnd()) {
-          repl._insertString(completionPreview);
         }
       }
       completionPreview = null;
@@ -467,7 +462,7 @@ function setupPreview(repl, contextSymbol, bufferSymbol, active) {
       previewLine += completionPreview;
     }
 
-    getInputPreview(previewLine, inputPreviewCallback);
+    getInputPreview(repl.line, inputPreviewCallback);
     if (wrapped) {
       getInputPreview(previewLine, inputPreviewCallback);
     }

test/parallel/test-repl-prevent-unwanted-autocompletion-on-enter.js

@@ -0,0 +1,35 @@
+'use strict';
+require('../common');
+const repl = require('repl');
+const { describe, it } = require('node:test');
+const ArrayStream = require('../common/arraystream');
+const assert = require('assert');
+const outputStream = new ArrayStream();
+let accum = '';
+outputStream.write = (data) => accum += data.replace('\r', '');
+
+function prepareREPL() {
+  const replServer = repl.start({
+    prompt: '',
+    input: new ArrayStream(),
+    output: outputStream,
+    allowBlockingCompletions: true,
+  });
+
+
+  return replServer;
+}
+
+
+describe('REPL Prevent unwanted autocompletion on pressing Enter', () => {
+  const code = [
+    'typeof Reflect.construct',
+    'typeof Reflect.const',
+  ];
+
+  it(`should not autocomplete constructor`, async () => {
+    const { input } = prepareREPL();
+    input.run(code);
+    assert.strictEqual(accum, '\'function\'\n\'undefined\'\n');
+  });
+});