Merge pull request #242 from vslio/prevent-crash-when-window-null

nicolasbeauvais · web-flow · commit 205939fe8dca · 2020-10-02T15:00:38.000+02:00
Prevent crash when window is null
diff --git a/src/share-network.js b/src/share-network.js
@@ -222,6 +222,9 @@ export default {
         ',screenY=' + this.popup.top
       )
 
+      // If an adblocker prevent popups, popup.window stays undefined and we can't display it       
+      if (!this.popup.window) return
+
       this.popup.window.focus()
 
       // Create an interval to detect popup closing event

Original file line number	Diff line number	Diff line change
`@@ -222,6 +222,9 @@ export default {`
`222`	`222`	`',screenY=' + this.popup.top`
`223`	`223`	`)`
`224`	`224`
	`225`	`+ // If an adblocker prevent popups, popup.window stays undefined and we can't display it`
	`226`	`+ if (!this.popup.window) return`
	`227`	`+`
`225`	`228`	`this.popup.window.focus()`
`226`	`229`
`227`	`230`	`// Create an interval to detect popup closing event`