Address AI review

Author: afitzek

packages/cli/src/controllers/role.controller.ts

@@ -37,7 +37,6 @@ export class RoleController {
 		_res: Response,
 		@Param('slug') slug: string,
 	): Promise<RoleDTO> {
-		console.log('getRoleBySlug', slug);
 		return await this.roleService.getRole(slug);
 	}
 
@@ -72,7 +71,6 @@ export class RoleController {
 		_res: Response,
 		@Body createRole: CreateRoleDto,
 	): Promise<RoleDTO> {
-		console.log('createRole', createRole);
 		return await this.roleService.createCustomRole(createRole);
 	}
 }

packages/cli/test/integration/controllers/role.controller-db.test.ts

@@ -16,7 +16,6 @@ describe('RoleController - Integration Tests', () => {
 	const testServer = setupTestServer({ endpointGroups: ['role'] });
 	let ownerAgent: SuperAgentTest;
 	let memberAgent: SuperAgentTest;
-	let generatedRoleSlug: string;
 
 	beforeAll(async () => {
 		await testDb.init();
@@ -105,14 +104,23 @@ describe('RoleController - Integration Tests', () => {
 				systemRole: false,
 			},
 		});
-
-		generatedRoleSlug = response.body.data.slug;
 	});
 
 	it('should update a custom role', async () => {
 		//
 		// ARRANGE
 		//
+		const createRoleDto: CreateRoleDto = {
+			displayName: 'Custom Project Role',
+			description: 'A custom role for project management',
+			roleType: 'project',
+			scopes: ['workflow:read', 'workflow:create'].sort(),
+		};
+
+		const createResponse = await ownerAgent.post('/roles').send(createRoleDto).expect(200);
+
+		expect(createResponse.body?.data?.slug).toBeDefined();
+
 		const updateRoleDto: UpdateRoleDto = {
 			displayName: 'Custom Project Role Updated',
 			description: 'A custom role for project management - updated',
@@ -122,7 +130,7 @@ describe('RoleController - Integration Tests', () => {
 		// ACT
 		//
 		const response = await ownerAgent
-			.patch(`/roles/${generatedRoleSlug}`)
+			.patch(`/roles/${createResponse.body.data.slug}`)
 			.send(updateRoleDto)
 			.expect(200);
 

packages/cli/test/integration/controllers/role.controller.test.ts

@@ -417,7 +417,7 @@ describe('RoleController', () => {
 			//
 			// ACT
 			//
-			const response = await ownerAgent.patch(`/roles/${roleSlug}`).send(updateRoleDto);
+			const response = await ownerAgent.patch(`/roles/${roleSlug}`).send(updateRoleDto).expect(200);
 
 			//
 			// ASSERT