Basic Auth

[agieocean]

I'm getting the following error trying to access an endpoint with auth enabled:

Traceback (most recent call last):                                            File "/home/ag/Documents/piermesh/lib/python3.11/site-packages/microdot/microdot.py", line 1394, in dispatch_request
    res = await invoke_handler(f, req, **req.url_args)                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                        File "/home/ag/Documents/piermesh/lib/python3.11/site-packages/microdot/microdot.py", line 28, in invoke_handler
    ret = await handler(*args, **kwargs)                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                      File "/home/ag/Documents/piermesh/lib/python3.11/site-packages/microdot/auth.py", line 30, in wrapper                                                     return await invoke_handler(self.error_callback, request)                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ag/Documents/piermesh/lib/python3.11/site-packages/microdot/microdot.py", line 30, in invoke_handler
    ret = await asyncio.get_running_loop().run_in_executor(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "uvloop/loop.pyx", line 2729, in uvloop.loop.Loop.run_in_executor
  File "/usr/lib/python3.11/concurrent/futures/thread.py", line 169, in submit
    raise RuntimeError('cannot schedule new futures after '
RuntimeError: cannot schedule new futures after interpreter shutdown

The auth is configured like so:

self.app = Microdot()          
self.auth = BasicAuth(self.app)            
                                 
@self.auth.authenticate 
async def verify_user(request, username, password):
    if username == "admin":
        if password == self.adminkey:
            return {"user": "admin"}  
                                                                                                                                                                                              

@self.app.get("/admin")                                                     
@self.auth                                                                  
async def admin(request):                                                                                                            

This started after adding the auth code

[miguelgrinberg]

Do you have an error callback set up in your BasicAuth object? Can I see it please?

[agieocean]

I hadn't set one up but I tried and still got the same error and it didn't seem to get called because nothing additional gets logged

def authErrorCallback(ob, request):
    logger.error(ob)                                                     
    return '', ob.error_status, { 'WWW-Authenticate': '{} realm="{}", charset="{}"'.format(ob.scheme, ob.realm, ob.charset)}
                                                                                                                                                        
self.auth.error_callback = authErrorCallback

I did also try removing self.app to match up better with the example https://github.com/miguelgrinberg/microdot/blob/main/examples/auth/basic_auth.py but nothing changed

Additionally the feedback I get from the browser is just the text "Internal server error"

[miguelgrinberg]

I'm sorry, this was a silly ask, the basic auth class does not give the application an option to set an error handler, it uses its own internal one.

I think I have a basic understanding now what's going on, but it must be related to a limitation or bug in Python's executors. I just pushed a fix to avoid using executors for this (it isn't actually needed anyway). My hope is that with this change the issue will be bypassed. Could you install Microdot from the main branch in this repository and retest?

[agieocean]

That did it, no changes needed on my end, thank you so much!

[miguelgrinberg]

v2.3.2 is now released with this fix.