Skip to content

Commit 7c38701

Browse files
chore: update OperationBuilder documentation now that an Option is no longer passed.
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
1 parent af36091 commit 7c38701

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

hir-macros/src/operation.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ pub struct OpDefinition {
5656
/// Indicates whether the current operation could belong to a [`SymbolTable`].
5757
///
5858
/// If true, this operation's builder will have an additional parameter of type
59-
///`parent_symbol_table: Option<&mut SymbolTableRef>`. `None` is currently only used in testing.
59+
///`parent_symbol_table: &mut SymbolTableRef`.
6060
belongs_in_symbol_table: bool,
6161
/// The symbolic references held by this op
6262
symbols: Vec<Symbol>,
@@ -149,6 +149,7 @@ impl OpDefinition {
149149
};
150150
let mut create_params = vec![];
151151
let (_, mut fields) = fields.split();
152+
152153
// Compute the absolute ordering of op parameters as follows:
153154
//
154155
// * By default, the ordering is implied by the order of field declarations in the struct
@@ -352,9 +353,9 @@ impl OpDefinition {
352353
}
353354
}
354355

355-
// If the operations has the "BelongsInSymbolTable" trait, then add an additional parameter
356-
// to the Operation::create and OpBuilder function of type:
357-
// parent_symbol_table: Option<&mut SymbolTableRef>,
356+
// If the operations has the "BelongsInSymbolTable" trait, then an additional parameter is
357+
// added to the Operation::create and OpBuilder function of type:
358+
// parent_symbol_table: &mut SymbolTableRef,
358359
// This is a reference to the symbol table of the parent where this operation will be added.
359360
if self
360361
.traits

0 commit comments

Comments
 (0)