trying to fix the weird test

Author: gvnc

cluster-autoscaler/cloudprovider/oci/nodepools/oci_manager.go

@@ -449,11 +449,7 @@ func (m *ociManagerImpl) forceRefresh() error {
 	}
 
 	m.lastRefresh = time.Now()
-	if m.cfg == nil {
-		klog.Errorf("manager config is nil")
-	} else {
-		klog.Infof("Refreshed NodePool list, next refresh after %v", m.lastRefresh.Add(m.cfg.Global.RefreshInterval))
-	}
+	klog.Infof("Refreshed NodePool list, next refresh after %v", m.lastRefresh.Add(m.cfg.Global.RefreshInterval))
 	return nil
 }
 

cluster-autoscaler/cloudprovider/oci/nodepools/oci_manager_test.go

@@ -11,14 +11,14 @@ import (
 	"net/http"
 	"reflect"
 	"testing"
+	"time"
 
 	apiv1 "k8s.io/api/core/v1"
 	"k8s.io/autoscaler/cluster-autoscaler/cloudprovider"
 	"k8s.io/autoscaler/cluster-autoscaler/cloudprovider/oci/vendor-internal/github.com/oracle/oci-go-sdk/v65/common"
 	kubeletapis "k8s.io/kubelet/pkg/apis"
 
 	ocicommon "k8s.io/autoscaler/cluster-autoscaler/cloudprovider/oci/common"
-	npconsts "k8s.io/autoscaler/cluster-autoscaler/cloudprovider/oci/nodepools/consts"
 	oke "k8s.io/autoscaler/cluster-autoscaler/cloudprovider/oci/vendor-internal/github.com/oracle/oci-go-sdk/v65/containerengine"
 )
 
@@ -447,11 +447,10 @@ func TestNodeGroupAutoDiscovery(t *testing.T) {
 	nodePoolCache := newNodePoolCache(nil)
 	nodePoolCache.okeClient = mockOKEClient{}
 
-	cloudConfig, err := ocicommon.CreateCloudConfig("", common.DefaultConfigProvider(), npconsts.OciNodePoolResourceIdent)
-	if cloudConfig == nil || err != nil {
-		//klog.Infof("Error: cloudConfig is nil. %s", err)
-		t.Errorf("Error: cloudConfig is nil. %s", err)
-	}
+	cloudConfig := &ocicommon.CloudConfig{}
+	cloudConfig.Global.RefreshInterval = 5 * time.Minute
+	cloudConfig.Global.CompartmentID = autoDiscoveryCompartment
+
 	manager := &ociManagerImpl{
 		nodePoolCache:   nodePoolCache,
 		nodeGroups:      []nodeGroupAutoDiscovery{*nodeGroup},