fix(ttl): fixing infinit looping on etcd3 client with a max ttl

Author: willgm

src/express-session-etcd3.ts

@@ -7,6 +7,11 @@ import debug from 'debug'
  */
 export const oneDay = 86400
 
+/**
+ * Max TTL time to leasing on ETCD3 Client in seconds.
+ */
+export const maxTTL = 6442450
+
 /**
  * Configuration options for the etcd v3
  */
@@ -193,6 +198,14 @@ export default class Etcd3Store extends Store {
    * Get the Time to Live (`ttl`) of the session
    */
   private getTTL(sess: Express.SessionData, sid: string): number {
+    const rawTTL = this.getRawTTL(sess, sid)
+    return rawTTL > maxTTL ? maxTTL : rawTTL
+  }
+
+  /**
+   * Get the raw Time to Live (`ttl`) of the session from the data sources
+   */
+  private getRawTTL(sess: Express.SessionData, sid: string): number {
     const storeTtl: any = (this as any)['ttl']
     if (typeof storeTtl === 'number') return storeTtl
     if (typeof storeTtl === 'string') return Number(storeTtl)

test/express-session-etcd3.test.ts

@@ -1,5 +1,10 @@
 import { DeleteBuilder, MultiRangeBuilder, SingleRangeBuilder } from 'etcd3/lib/src'
-import Etcd3Store, { Etcd3StoreOptions, defaultOptions, oneDay } from '../src/express-session-etcd3'
+import Etcd3Store, {
+  Etcd3StoreOptions,
+  defaultOptions,
+  oneDay,
+  maxTTL
+} from '../src/express-session-etcd3'
 import { Etcd3 } from 'etcd3'
 import { PutBuilder } from 'etcd3/lib/src/builder'
 import { anotherPrefix, createTestClientAndKeys, sessionData, tearDownTestClient } from './utils'
@@ -450,5 +455,14 @@ describe('Etcd3Store test suit', () => {
       const session = { ...sessionData, cookie: { ...sessionData.cookie, maxAge: 'what?' as any } }
       expect(subject['getTTL'](session, null)).toBe(oneDay)
     })
+
+    it('should use max ttl value if the configured value is greater than it', async () => {
+      const { subject } = await createSubject()
+      const session = {
+        ...sessionData,
+        cookie: { ...sessionData.cookie, maxAge: maxTTL * 1000 * 2 }
+      }
+      expect(subject['getTTL'](session, null)).toBe(maxTTL)
+    })
   })
 })