refactor into scale_down/scale_up functions (#103)

* refactor into scale_down/scale_up functions

* use f-literals

* add a test for --include-resources

Author: hjacobs

kube_downscaler/cmd.py

@@ -10,7 +10,7 @@ def check_include_resources(value):
     resources = frozenset(value.split(","))
     if not resources <= VALID_RESOURCES:
         raise argparse.ArgumentTypeError(
-            f"--include-resources argument should contain a subset of [{', '.join(VALID_RESOURCES)}]"
+            f"--include-resources argument should contain a subset of [{', '.join(sorted(VALID_RESOURCES))}]"
         )
     return value
 
@@ -38,8 +38,7 @@ def get_parser():
         "--include-resources",
         type=check_include_resources,
         default="deployments",
-        help="Downscale resources of this kind as comma separated list. [%s] (default: deployments)"
-        % (",".join(VALID_RESOURCES)),
+        help=f"Downscale resources of this kind as comma separated list. [{', '.join(sorted(VALID_RESOURCES))}] (default: deployments)",
     )
     parser.add_argument(
         "--grace-period",

kube_downscaler/main.py

@@ -83,7 +83,7 @@ def run_loop(
                 deployment_time_annotation=deployment_time_annotation,
             )
         except Exception as e:
-            logger.exception("Failed to autoscale : %s", e)
+            logger.exception(f"Failed to autoscale: {e}")
         if run_once or handler.shutdown_now:
             return
         with handler.safe_exit():