Skip to content

Commit 2edbce1

Browse files
authored
updated to r167 (#4869)
1 parent 4f7e758 commit 2edbce1

File tree

7 files changed

+2349
-976
lines changed

7 files changed

+2349
-976
lines changed

package-lock.json

Lines changed: 2335 additions & 967 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/model-viewer-effects/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ npm install three @google/model-viewer @google/model-viewer-effects
5252
<script type="importmap">
5353
{
5454
"imports": {
55-
"three": "https://cdn.jsdelivr.net/npm/three@^0.164.1/build/three.module.min.js"
55+
"three": "https://cdn.jsdelivr.net/npm/three@^0.167.1/build/three.module.min.js"
5656
}
5757
}
5858
</script>

packages/model-viewer-effects/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,10 @@
100100
"rollup-plugin-dts": "^4.2.2",
101101
"rollup-plugin-polyfill": "^3.0.0",
102102
"rollup-plugin-terser": "^7.0.2",
103-
"three": "^0.164.1",
103+
"three": "^0.167.1",
104104
"typescript": "4.8.4"
105105
},
106106
"publishConfig": {
107107
"access": "public"
108108
}
109-
}
109+
}

packages/model-viewer/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
"@monogrid/gainmap-js": "^3.0.1"
8888
},
8989
"peerDependencies": {
90-
"three": "^0.164.1"
90+
"three": "^0.167.1"
9191
},
9292
"devDependencies": {
9393
"@rollup/plugin-commonjs": "^22.0.1",
@@ -110,9 +110,9 @@
110110
"rollup-plugin-polyfill": "^3.0.0",
111111
"rollup-plugin-terser": "^7.0.2",
112112
"typescript": "4.8.4",
113-
"three": "^0.164.1"
113+
"three": "^0.167.1"
114114
},
115115
"publishConfig": {
116116
"access": "public"
117117
}
118-
}
118+
}

packages/model-viewer/src/test/three-components/ARRenderer-spec.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ class MockXRFrame implements XRFrame {
3535
return {} as XRPose;
3636
}
3737

38+
// We don't use getDepthInformation()
39+
getDepthInformation(_view: XRView): XRCPUDepthInformation|null|undefined {
40+
return;
41+
}
42+
3843
getViewerPose(_referenceSpace?: XRReferenceSpace): XRViewerPose {
3944
// Rotate 180 degrees on Y (so it's not the default)
4045
// and angle 45 degrees towards the ground, like a phone.

packages/model-viewer/src/three-components/ARRenderer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ export class ARRenderer extends EventDispatcher<
655655

656656
let hit = null;
657657
if (finger.results.length > 0) {
658-
hit = this.getHitPoint(finger.results[0])
658+
hit = this.getHitPoint(finger.results[0]);
659659
}
660660
if (hit == null) {
661661
hit = this.getTouchLocation();

packages/modelviewer.dev/examples/postprocessing/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<script type="importmap">
3333
{
3434
"imports": {
35-
"three": "https://cdn.jsdelivr.net/npm/three@^0.164.1/build/three.module.min.js"
35+
"three": "https://cdn.jsdelivr.net/npm/three@^0.167.1/build/three.module.min.js"
3636
}
3737
}
3838
</script>
@@ -104,7 +104,7 @@ <h2 class="demo-title">Setup Post Processing</h2>
104104
<script type="importmap-noexecute">
105105
{
106106
"imports": {
107-
"three": "https://cdn.jsdelivr.net/npm/three@^0.164.1/build/three.module.min.js"
107+
"three": "https://cdn.jsdelivr.net/npm/three@^0.167.1/build/three.module.min.js"
108108
}
109109
}
110110
</script>

0 commit comments

Comments
 (0)