StyleBoxTexture Texture Margin act like a MarginContainer

[xDovos]

Tested versions

4.4.1 stable
4.5.Beta7

System information

Godot v4.5.beta7 - Windows 10 (build 19045) - Multi-window, 2 monitors - OpenGL 3 (Compatibility) - NVIDIA GeForce RTX 2060 SUPER (NVIDIA; 32.0.15.8115) - Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 threads) - 63.91 GiB memory

Issue description

after finally getting started on working with themes, i start to run into one issue after another. this one is what i understand the least.

why is the TEXTURE margin of a background StyleBoxTexture acting like a MarginContainer placed between the node and it's sub nodes? it should be purely on the texture like for a NinePatchRect and ignore the children like the label for the button.

the top one is a button and the bottom one is a NinePatchRect + Label.
both have the same texture and regionRect for the margin and both are at their minimum height.
i would expect that the theme behaves more like the NinePatchRect and maybe has a separate MarginContainer margin for the sub children that can be configured that doesn't affect the background texture.
the thing that i find weird is that the Expand Margins of the StyleBoxContainer are purely texture based and don't affect anything else of the node. i would expect both of them to behave the same as it is texture settings and not node settings.
btw, this also shifts the Center position of the Label to the side if the needed margins for the texture aren't symetrical for the texture.

Steps to reproduce

• make a control scene
• add button
• add a theme
• give the button in the theme a StyleBoxTexture for the Normal style
• set the texture and texture Margin like shown above
• add a NinePatchRect
• add the texture
• set the same margins
• add a Label as Child.
• set the label text as Centered.

Minimal reproduction project (MRP)

N/A

[AThousandShips]

I assume you're not changing the content margins? They default to -1 which means to use the texture margins, try changing them

[xDovos]

oh that's interesting. if i change them from -1 to 0, it behaves like i expected it to.
now the question is why that is the case? shouldn't these be independent of each other with only the minimal required size being limited by what is bigger? right now these seem to be additive in their minimal size.

[AThousandShips]

It isn't additive, it adds the margin based on the different types of StyleBox, in the case of the texture one it picks the texture margins, see StyleBox.content_margin_bottom and StyleBoxTexture.texture_margin_bottom

[xDovos]

it goes from 40 px to 24 px minimal height if i set the content margin to 0 and that seems to be the minimal height of the label inside the button as if i remove the text, i can collapse it to 0 height.
so if i have it at -1 i get the content minimal height (24) + the texture margin (2 x 8) as minimal height.
so with 0 it completely ignores the texture margin and with -1 it adds two minimal heights together.
tho knowing that now, i just need to set the content margin to 0 and be good. tho it is for me unexpected behaviour

[AThousandShips]

Button handles size based on the text yes, it adds the margin to the minimal size, I'd expect that myself

[xDovos]

i did expect it to choose the bigger value.
i just didn't expect that the texture is affecting the content. that means that i need to set the content margin myself to be able to use assymetrical textures/textures with different margins for the different states.
thanks for clarifying