File tree Expand file tree Collapse file tree 4 files changed +9
-49
lines changed
packages/url_launcher/url_launcher_web Expand file tree Collapse file tree 4 files changed +9
-49
lines changed Original file line number Diff line number Diff line change 1
- ## 2.4.2
1
+ ## NEXT
2
2
3
- * Ensure link widget merge its semantic node with its children to avoid duplicate nodes.
4
3
* Updates minimum supported SDK version to Flutter 3.29/Dart 3.7.
5
4
6
5
## 2.4.1
Original file line number Diff line number Diff line change @@ -208,43 +208,6 @@ void main() {
208
208
maxScrolls: 1000 ,
209
209
);
210
210
});
211
-
212
- testWidgets ('MergeSemantics is always present to avoid duplicate nodes' , (
213
- WidgetTester tester,
214
- ) async {
215
- await tester.pumpWidget (
216
- MaterialApp (
217
- home: Scaffold (
218
- body: Column (
219
- children: < Widget > [
220
- WebLinkDelegate (
221
- TestLinkInfo (
222
- uri: Uri .parse ('https://dart.dev/xyz' ),
223
- target: LinkTarget .blank,
224
- builder: (BuildContext context, FollowLink ? followLink) {
225
- return ElevatedButton (
226
- onPressed: followLink,
227
- child: const Text ('First Button' ),
228
- );
229
- },
230
- ),
231
- ),
232
- ],
233
- ),
234
- ),
235
- ),
236
- );
237
-
238
- await tester.pumpAndSettle ();
239
-
240
- final Finder buttonFinder = find.byType (ElevatedButton );
241
- expect (buttonFinder, findsOneWidget);
242
-
243
- final Element buttonElement = tester.element (buttonFinder);
244
- final MergeSemantics ? parentWidget =
245
- buttonElement.findAncestorWidgetOfExactType <MergeSemantics >();
246
- expect (parentWidget, isNotNull);
247
- });
248
211
});
249
212
250
213
group ('Follows links' , () {
Original file line number Diff line number Diff line change @@ -117,15 +117,13 @@ class WebLinkDelegateState extends State<WebLinkDelegate> {
117
117
}
118
118
119
119
Widget _buildChild (BuildContext context) {
120
- return MergeSemantics (
121
- child: Semantics (
122
- link: true ,
123
- identifier: _semanticsIdentifier,
124
- linkUrl: widget.link.uri,
125
- child: widget.link.builder (
126
- context,
127
- widget.link.isDisabled ? null : _followLink,
128
- ),
120
+ return Semantics (
121
+ link: true ,
122
+ identifier: _semanticsIdentifier,
123
+ linkUrl: widget.link.uri,
124
+ child: widget.link.builder (
125
+ context,
126
+ widget.link.isDisabled ? null : _followLink,
129
127
),
130
128
);
131
129
}
Original file line number Diff line number Diff line change @@ -2,7 +2,7 @@ name: url_launcher_web
2
2
description : Web platform implementation of url_launcher
3
3
repository : https://github.com/flutter/packages/tree/main/packages/url_launcher/url_launcher_web
4
4
issue_tracker : https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
5
- version : 2.4.2
5
+ version : 2.4.1
6
6
7
7
environment :
8
8
sdk : ^3.7.0
You can’t perform that action at this time.
0 commit comments