Skip to content

Temporary directory not cleaned up (regression) #26

@phloxic

Description

@phloxic

With recent changes shutil now tries (and fails silently) to remove a tree with path generated here: https://github.com/flavioribeiro/video-thumbnail-generator/blob/master/generator#L195 which is actually the so-called 'prefix' of the temporary png filenames.

shutil instead should try to remove TMP_FRAMES_PATH presumably.

However I am not sure how this fares with the new directory processing feature.
I also don't know in which scenario the TMP_FRAMES_PATH is recreated: https://github.com/flavioribeiro/video-thumbnail-generator/blob/master/generator#L193-L194 (instead of creating a new temporary directory safely).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions