Fix browser condition for astring (#1200)

Author: ije

server/build_resolver.go

@@ -578,10 +578,15 @@ func (ctx *BuildContext) resolveConditionExportEntry(conditions npm.JSONObject,
 	var conditionFound bool
 
 	if ctx.isBrowserTarget() {
-		conditionFound = applyCondition("browser")
+		conditionName := "browser"
+		// [workaround] fix astring entry in browser
+		if ctx.esmPath.PkgName == "astring" {
+			conditionName = "import"
+		}
+		conditionFound = applyCondition(conditionName)
 	} else if ctx.isDenoTarget() {
 		conditionName := "deno"
-		// [workaround] to support ssr in Deno, use `node` condition for solid-js < 1.6.0
+		// [workaround] to support solid-js/ssr in Deno, use `node` condition for < 1.6.0
 		if ctx.esmPath.PkgName == "solid-js" && semverLessThan(ctx.esmPath.PkgVersion, "1.6.0") {
 			conditionName = "node"
 		}
@@ -607,7 +612,7 @@ LOOP:
 		module := false
 		prefered := ""
 		switch conditionName {
-		case "module", "import", "es2015":
+		case "import", "module", "es2015":
 			module = true
 			prefered = "module"
 		case "require":

test/issue-1199/test.ts

@@ -0,0 +1,10 @@
+import { assert } from "jsr:@std/assert";
+
+// related issue: https://github.com/esm-dev/esm.sh/issues/1199
+Deno.test(
+  "fix astring entry in browser",
+  async () => {
+    const mod = await import("http://localhost:8080/astring@1.9.0?target=es2022");
+    assert(typeof mod.generate === "function");
+  },
+);