Skip to content

Commit 2bc5498

Browse files
authored
Fix failing thread pool test on low core count machines (#134069)
On lower core count machines (such as macbooks) we hit hard limits on thread pool sizes. This adjusts this test to include thread pools for which hard limits apply. Closes #133854
1 parent 99ff870 commit 2bc5498

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

server/src/test/java/org/elasticsearch/threadpool/UpdateThreadPoolSettingsTests.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,11 @@ public void testWriteThreadPoolsMaxSize() throws InterruptedException {
7979
}
8080

8181
private static int getExpectedThreadPoolSize(Settings settings, String name, int size) {
82-
if (name.equals(ThreadPool.Names.WRITE) || name.equals(Names.SYSTEM_WRITE) || name.equals(Names.SYSTEM_CRITICAL_WRITE)) {
82+
if (name.equals(ThreadPool.Names.WRITE)
83+
|| name.equals(Names.SYSTEM_WRITE)
84+
|| name.equals(Names.SYSTEM_CRITICAL_WRITE)
85+
|| name.equals(Names.WRITE_COORDINATION)
86+
|| name.equals(Names.SYSTEM_WRITE_COORDINATION)) {
8387
return Math.min(size, EsExecutors.allocatedProcessors(settings));
8488
} else {
8589
return size;

0 commit comments

Comments
 (0)