Skip to content

Commit 646fed0

Browse files
committed
feat(icons): added new icons #277
1 parent d81456f commit 646fed0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+508
-79
lines changed

.changeset/sharp-bars-share.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@ebay/skin": minor
3+
"@ebay/ebayui-core": minor
4+
"@ebay/ui-core-react": minor
5+
---
6+
7+
feat(icons): added new icons #277

packages/skin/ICON-CREATION.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,7 @@ The viewbox given will be translated to the `width` and `height` that the icons
2222

2323
## Step 2: Run scripts
2424

25-
To properly setup the icon after it is placed in the `src/svg/icon` directory, run `node scripts genSVG` from the root of the skin project. This will properly setup the icon in docs, in the `icon.svg` bundle, and generate the CSS needed for the icon.
26-
27-
If you get an error saying an executable doesn't exist, it probably means you'll need to install Playwright. To do so, run `npx playwright install` and try again.
28-
29-
Afterward, you should run `npm run build` in order to also copy all those files to `dist` as well as to the docs.
25+
To properly setup the icon after it is placed in the `src/svg/icon` directory, run `node run build` from the root of the skin project. This will properly setup the icon in docs, in the `icon.svg` bundle, generate the CSS needed for the icon, and copy all the SVGs into the dist folder.
3026

3127
## Appendix
3228

Lines changed: 5 additions & 0 deletions
Loading
Lines changed: 5 additions & 0 deletions
Loading
Lines changed: 5 additions & 0 deletions
Loading
Lines changed: 5 additions & 0 deletions
Loading
Lines changed: 5 additions & 0 deletions
Loading
Lines changed: 5 additions & 0 deletions
Loading
Lines changed: 5 additions & 0 deletions
Loading
Lines changed: 9 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)