fixed: Handle proxy errors

Author: chimurai

index.js

@@ -6,12 +6,16 @@ var httpProxyMiddleware = function (context, opts) {
     var proxyOptions = opts || {};
     var proxy = httpProxy.createProxyServer(proxyOptions);
 
-    console.log('[http-proxy-middleware] Proxy created:', context, proxyOptions.target);
+    console.log('[HPM] Proxy created:', context, proxyOptions.target);
 
     if (proxyOptions.proxyHost) {
         proxy.on('proxyReq', utils.proxyReqHost);
     }
 
+    proxy.on('error', function (err, req, res) {
+        utils.proxyError(err, req, res, proxyOptions);
+    });
+
     return fnProxyMiddleWare;
 
     function fnProxyMiddleWare (req, res, next) {

lib/utils.js

@@ -1,4 +1,5 @@
 module.exports = {
-    hasContext: require('./utils/has-context'),
-    proxyReqHost: require('./utils/proxy-req-host')
+    hasContext   : require('./utils/has-context'),
+    proxyReqHost : require('./utils/proxy-req-host'),
+    proxyError   : require('./utils/proxy-error')
 }

lib/utils/proxy-error.js

@@ -0,0 +1,7 @@
+module.exports = function(err, req, res, proxyOptions) {
+    var targetUri = proxyOptions.target.host + req.url;
+    console.log('[HPM] Proxy error:', err.code, targetUri);
+
+    res.writeHead(500);
+    res.end('Error occured while trying to proxy to: '+ proxyOptions.target.host + req.url);
+};

test/utils-proxy-error.js

@@ -0,0 +1,42 @@
+var expect = require('chai').expect;
+var proxyError = require('../lib/utils/proxy-error');
+
+var mockError = {
+    code : 'ECONNREFUSED'
+};
+
+
+var mockReq = {
+    url : '/api'
+};
+
+var proxyOptions = {
+    target : {
+        host : 'localhost.dev'
+    }
+};
+
+describe('utils#proxyError(err, req, res, proxyOptions)', function () {
+
+    it('should set the header: host to match the target host', function () {
+        var httpErrorCode;
+        var errorMessage;
+
+        var mockRes = {
+            writeHead : function (v) {
+                httpErrorCode = v;
+                return v;
+            },
+            end : function (v) {
+                errorMessage = v;
+                return v;
+            }
+        };
+
+        proxyError(mockError, mockReq, mockRes, proxyOptions);
+
+        expect(httpErrorCode).to.equal(500);
+        expect(errorMessage).to.equal('Error occured while trying to proxy to: localhost.dev/api');
+    });
+
+});