🐛 Type-aware rules fail to work

[0x80]

Environment information

biome rage
CLI:
  Version:                      2.2.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  BIOME_THREADS:                unset
  NO_COLOR:                     unset
  TERM:                         xterm-256color
  JS_RUNTIME_VERSION:           unset
  JS_RUNTIME_NAME:              unset
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Error:                        The configuration schema version does not match the CLI version 2.2.0
  Status:                       Loaded with errors
  Path:                         biome.jsonc
  Formatter enabled:            true
  Linter enabled:               true
  Assist enabled:               true
  VCS enabled:                  true

Workspace:
  Open Documents:               0

What happened?

1. Clone this repository https://github.com/0x80/mono-ts
2. Run pnpm i
3. Remove some await statements, for example in services/api/src/v1/handlers.ts
4. Run pnpm check-biome

Expected result

I would expect errors about floating promises.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

Project rules aren't enabled and recommended by default because they take a toll on the performance of Biome.

https://biomejs.dev/linter/domains/#project

[siketyan]

@ematipico It looks the project domain enabled: https://github.com/0x80/mono-ts/blob/ec7de1141239c95d8fb7d0633f67d90b3066b331/biome.jsonc#L7

[ematipico]

Ah. That wasn't clear at all to me. Apologies.

[ematipico]

The reason this doesn't work is that noFloatingPromises is a nursery rule. Nursery rules must be enabled explicitly.

[0x80]

@ematipico Awesome thank you!

But it makes me wonder if this is clear enough from the docs. I read this and because the rules are marked with "(recommended)" it was my assumption that by setting rules.recommended: true these would be activated.

Maybe it helps if they are (also) marked with "nursery" and have a link to where it is mentioned that nursery must be explicitly activated.

[ematipico]

Cheers for the suggestion

[0x80]

@ematipico Sorry to bother you again, but with nursery enabled I still don't get any error on missing await statements. What am I missing?

{
  "$schema": "https://biomejs.dev/schemas/2.2.2/schema.json",
  "linter": {
    "domains": {
      "react": "all",
      "next": "all",
      "project": "all",
      "test": "all"
    },
    "rules": {
      "recommended": true,
      "suspicious": {
        "noUnknownAtRules": "off" // required for tailwind?
      },
      "nursery": {
        /**
         * Nursery function are unstable and need to be activated explicitly
         */
        "noFloatingPromises": "error",
        "noImportCycles": "error",
        "noMisusedPromises": "error",
        "noUnnecessaryConditions": "error",
        // "noUnresolvedImports": "error", // Doesn't seem to understand node: prefix
        "useExhaustiveSwitchCases": "error"
      }
    }
  },
  "formatter": {
    "indentStyle": "space",
    "indentWidth": 2
  },
  "vcs": {
    "enabled": true,
    "clientKind": "git",
    "useIgnoreFile": true
  }
}

[ematipico]

It's hard to tell. Maybe a bug in the rule?

[0x80]

Ok, it seems like this issue should be re-opened then. I don't have permissions to do so.