Using @aws-sdk/signature-v4-multi-region with GET and querysttingss

[justin-masse]

Hello!

I am converting from using aws4 (npm package) to @aws-sdk/signature-v4-multi-region to sign my requests with sigv4 (and eventually sigv4a).

I have working signing code that works with GET and POST requests to a sigv4 enabled endpoint. The problem is when I add a query string like ?foo=bar to my GET request I get signature failures.

In aws4 package he built a bunch of custom stuff to handle this but I’m curious if there’s a way to do this with the supported signing packages?

     const sigV4a = new SignatureV4MultiRegion({
            credentials,
            region: 'us-east-1',
            service: 'execute-api',
            runtime: 'node', // SigV4A is only supported in Node.js
            sha256: Sha256,
      })

      const signingRequest: HttpRequest = {
            method: 'GET',
            headers: requestInit.headers,
            protocol: 'https',
            hostname: url.hostname,
            path: `${url.pathname}${url.search}`,
            body: requestInit.body as string | undefined,
      }

      const signingOptions: RequestSigningArguments = {
            signingRegion: '*',
      }

      const { method, headers, body } = await sigV4a.sign(signingRequest, signingOptions)
      return await fetch(url, { method, headers, body } as RequestInit)

code is pretty straight forward? Not sure how to add support when someone uses this for a request with query strings though?

[justin-masse]

I have tried adding to the HttpRequest with stuff like query: Object.fromEntries(url.searchParams.entries()) || undefined

[justin-masse]

Alright so this was just me being dumb...

path: ${url.pathname}${url.search}, was the issue... this was a byproduct of the switch from aws4 package... I just dropped the url.search off and moved it into query param: query: Object.fromEntries(url.searchParams.entries()) || undefined,

[github-actions[bot]]

Hello! Reopening this discussion to make it searchable.