Skip to content

Enable go vet's linters #2386

@tstirrat15

Description

@tstirrat15

The golangci-lint configuration doesn't currently include go vet's lint rules. There's a set of problems that can be caught by static analysis that won't be caught by the compiler, such as errors.As invocations where errors.As takes an any as its second arg.

We ran go vet ./... on the repo as a test, and it seems like most of the work here will be either reordering fields or adding names to structs whose order of instantiated fields don't match their order of declared fields, mostly in tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/toolingAffects the dev or user toolchain (e.g. tests, ci, build tools)hint/good first issueSomeone new could handle thishint/help wantedSomeone else needs to handle this

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions