-
Notifications
You must be signed in to change notification settings - Fork 340
Open
Labels
area/toolingAffects the dev or user toolchain (e.g. tests, ci, build tools)Affects the dev or user toolchain (e.g. tests, ci, build tools)hint/good first issueSomeone new could handle thisSomeone new could handle thishint/help wantedSomeone else needs to handle thisSomeone else needs to handle this
Description
The golangci-lint
configuration doesn't currently include go vet
's lint rules. There's a set of problems that can be caught by static analysis that won't be caught by the compiler, such as errors.As
invocations where errors.As
takes an any
as its second arg.
We ran go vet ./...
on the repo as a test, and it seems like most of the work here will be either reordering fields or adding names to structs whose order of instantiated fields don't match their order of declared fields, mostly in tests.
miparnisari
Metadata
Metadata
Assignees
Labels
area/toolingAffects the dev or user toolchain (e.g. tests, ci, build tools)Affects the dev or user toolchain (e.g. tests, ci, build tools)hint/good first issueSomeone new could handle thisSomeone new could handle thishint/help wantedSomeone else needs to handle thisSomeone else needs to handle this