[Bug] service_relation_client_resp_time return cpm, but service_relation_client_cpm return resp_time

[heidun]

Search before asking

• I had searched in the issues and found no similar issues.

Apache SkyWalking Component

OAP server (apache/skywalking)

What happened

It appears that the metric service_relation_client_resp_time returns CPM (calls per minute), whereas service_relation_client_cpm returns response time. The metric names seem to be inconsistent with the data they provide.

What you expected to happen

service_relation_client_resp_time return resp_time
service_relation_client_cpm return cpm

How to reproduce

try

Anything else

No response

Are you willing to submit a pull request to fix on your own?

• Yes I am willing to submit a pull request on my own!

Code of Conduct

• I agree to follow this project's Code of Conduct

[wu-sheng]

whereas service_relation_client_cpm returns response time

What do you mean? How does it return the response time? I am confused.

[wu-sheng]

Metrics names are defined through OAL script engine.

skywalking/oap-server/server-starter/src/main/resources/oal/core.oal

Lines 28 to 36 in 30702c7

	// Service relation scope metrics for topology
	service_relation_client_cpm = from(ServiceRelation.*).filter(detectPoint == DetectPoint.CLIENT).cpm();
	service_relation_server_cpm = from(ServiceRelation.*).filter(detectPoint == DetectPoint.SERVER).cpm();
	service_relation_client_call_sla = from(ServiceRelation.*).filter(detectPoint == DetectPoint.CLIENT).percent(status == true);
	service_relation_server_call_sla = from(ServiceRelation.*).filter(detectPoint == DetectPoint.SERVER).percent(status == true);
	service_relation_client_resp_time = from(ServiceRelation.latency).filter(detectPoint == DetectPoint.CLIENT).longAvg();
	service_relation_server_resp_time = from(ServiceRelation.latency).filter(detectPoint == DetectPoint.SERVER).longAvg();
	service_relation_client_percentile = from(ServiceRelation.latency).filter(detectPoint == DetectPoint.CLIENT).percentile2(10); // Multiple values including p50, p75, p90, p95, p99
	service_relation_server_percentile = from(ServiceRelation.latency).filter(detectPoint == DetectPoint.SERVER).percentile2(10); // Multiple values including p50, p75, p90, p95, p99